SAML new username issue

[makhoff]

Description:

Hello.
When I configured SAML with settings from this issue, new user created in format "Display Name, login" and I can't manage him from RocketChat console(only via REST API) .

In logs I see that parameter username received as "username":["XXX, YYY","TSTDMN\xxx.yyy"]" instead of ""username":["XXX, YYY"]"

Steps to reproduce:

1. Configure SAML with ADFS
2. Set "Generate Username" = false
3. Sign in with new SSO user

Expected behavior:

Got username in format ""username":["XXX, YYY"]"

Actual behavior:

Server Setup Information:

• Version of Rocket.Chat Server: 1.2.0
• Operating System: RHEL 7
• Deployment Method: on premise
• Number of Running Instances: 1
• DB Replicaset Oplog: Enabled
• NodeJS Version: 8.11.4
• MongoDB Version: 4.0.10

Additional context

Relevant logs:

RESULT :{"profile":{"inResponseToId":"id-JPKNNNsuCovo5t8CD","issuer":"http://MYDOMAIN.com/adfs/services/trust","nameID":"[email protected]","nameIDFormat":"urn:oasis:names:tc:SAML:1.1:nameid-format:emailAddress","sessionIndex":"_921934bf-672a-4364-b281-432732f36c6e",**"username":["DISPLAY NAME","DOMAIN\sAMAccountaname"],"**email":"MY_EMAIL","http://schemas-xmlsoap-org/ws/2005/05/identity/claims/name":"DISPLAY NAME",

[routerino]

Any progress on this? Encountering this identical issue and it's making me tear my hair out.

[1rV1N-git]

@makhoff Change in this place to "cn"