Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[sandstorm] Cull administrator options #1527

Closed
Sing-Li opened this issue Dec 1, 2015 · 8 comments
Closed

[sandstorm] Cull administrator options #1527

Sing-Li opened this issue Dec 1, 2015 · 8 comments

Comments

@Sing-Li
Copy link
Member

Sing-Li commented Dec 1, 2015

Not all administrator options should be exposed to a sandstorm admin user.

For example, LDAP or oauth settings do not make sense.

Want to back this issue? Post a bounty on it! We accept bounties via Bountysource.

@marceloschmidt
Copy link
Member

LDAP settings can be removed by removing the LDAP package.
Is there some way to remove packages in sandstorm?
Maybe the other oauth settings should also be triggered by custom packages?

@Sing-Li
Copy link
Member Author

Sing-Li commented Dec 1, 2015

Actually, it is probably OK to leave the package code in. The issue is centered around conditionally showing certain settings in the UI (when it is detected to be running under Sandstorm)

Please see this PR for an example -- https://github.com/RocketChat/Rocket.Chat/pull/1473/files

The UI is rendered depending on whether the code is running in Sandstorm. And so the admin UI should show only the settings that are meaningful to Sandstorm users.

@engelgabriel
Copy link
Member

Depends on #2250

@sampaiodiego
Copy link
Member

with #2361 this is now possible just have to block or hidden some settings when in sandstorm environment

@engelgabriel
Copy link
Member

We just need a full list of settings to block :)

@asthomasdk
Copy link

I have been trying to use the hidden settings - but they do not seem to have any effect.

Trying to browse through the source code, I can see how the block settings are translated into isDisabled - which is used in a few places in the UI. But I don't see anything using the hidden settings.

Unless I am missing something...

@engelgabriel
Copy link
Member

engelgabriel commented Dec 22, 2016

We will add some documentation

https://github.com/RocketChat/Rocket.Chat.Docs/issues/163

@marceloschmidt
Copy link
Member

Sandstorm is not supported anymore.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants