Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

API info shows tag of wrong version #1661

Closed
Sing-Li opened this issue Dec 15, 2015 · 2 comments
Closed

API info shows tag of wrong version #1661

Sing-Li opened this issue Dec 15, 2015 · 2 comments

Comments

@Sing-Li
Copy link
Member

Sing-Li commented Dec 15, 2015

{
"version": "0.9.0",
"compile": {
"date": "2015-12-14T13:02:12.661Z",
"nodeVersion": "v0.10.40",
"arch": "x64",
"platform": "linux",
"osRelease": "3.13.0-63-generic",
"totalMemmory": 7844462592,
"freeMemmory": 5097484288,
"cpus": 2
},
"travis": {
"buildNumber": "2626",
"branch": "master",
"tag": ""
},
"commit": {
"hash": "0ea50588e3b899d4d8e1173da4a661cf3654749b",
"date": "Mon Dec 14 10:55:53 2015 -0200",
"author": "Gabriel Engel",
"subject": "Merge pull request #1655 from RocketChat/develop"
},
"tag": "v0.8.0",
"branch": "HEAD"
}

Want to back this issue? Post a bounty on it! We accept bounties via Bountysource.

@engelgabriel
Copy link
Member

The TAGs happens after the PR.. so we need to think how to do it differently... not sure it is possible to change both at the same time. The iead was to stop building assets on master form PRs, and only build from TAGs.. that would fix this problem.

@geekgonecrazy
Copy link
Contributor

image

Now that our api info is like this, is this what we were aiming for?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants