-
Notifications
You must be signed in to change notification settings - Fork 10.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sensitive server data exposed for non logged in users. #1731
Comments
i can confirm this on https://demo.rocket.chat/api/info |
Perhaps make the information visible somewhere on the administration pages and disable "/api/info" for production systems? |
we use the |
I see, then is there a reason for information such as kernel version or available ram also being publicly exposed? Could just remove that information from it. |
it was mainly to help us give better support, but you are right, we will remove that. |
we might want to public-key encrypt a sysinfo-blob for support ? |
Maybe we just make this route only available to admin? Because I do think some points the info could be good for troubleshooting. I also like the idea of pub-key encrypt |
Today you only get the chat version from api/info. If there is still something relevant in this issue, please reopen this with updated details. Thanks! |
Question: would it be a problem to block "/api/info" on nginx proxy side, e.g.:
Or has it still to be public for mobile and desktop clients? |
@localguru I believe the new Android app uses this. The iOS app possibly uses this as well. |
When accessing to "/api/info", some data like server OS, kernel version, cpu and ram, as well as other sensitive data is exposed, this could represent a security issue. All sensitive information should be remove from this response.
The text was updated successfully, but these errors were encountered: