Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add temporary image and map embed to support bot writers #177

Closed
Sing-Li opened this issue Jun 10, 2015 · 2 comments
Closed

Add temporary image and map embed to support bot writers #177

Sing-Li opened this issue Jun 10, 2015 · 2 comments
Milestone

Comments

@Sing-Li
Copy link
Member

Sing-Li commented Jun 10, 2015

We can't quite wait until 1.0. Because bot writers need to do this now:

embed

Propose to add temporary (hacky, throwaway) implementation of image and map embed to support bot writers. PR follows.

In the PR, a modular implementation using the brand-new renderMessage callback hooks is also included in the packages directory. BUT that doesn't work because there is currently no way to say 'run mines first, and don't run any other in the chain after -- if I say so'.

@henryxie2093
Copy link

cool,good job

@Sing-Li
Copy link
Member Author

Sing-Li commented Jun 14, 2015

Closing. PR was manually merged due to the 'slippery finger effect' :)

@Sing-Li Sing-Li closed this as completed Jun 14, 2015
@rodrigok rodrigok modified the milestone: v0.3 Jun 25, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants