Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Custom Fields are required even with "required: false" #17974

Closed
wreiske opened this issue Jun 19, 2020 · 2 comments · Fixed by #18838
Closed

Custom Fields are required even with "required: false" #17974

wreiske opened this issue Jun 19, 2020 · 2 comments · Fixed by #18838
Assignees
@gabriellsh @pierre-lehnen-rc
Labels
stat: stale Stale issues will be automatically closed if no activity stat: triaged Issue reviewed and properly tagged type: bug
Milestone
3.7.0

Comments

@wreiske
Copy link
Contributor

wreiske commented Jun 19, 2020 •
edited
Loading

Description:

Custom fields are required even when required: false is set.

Steps to reproduce:

  1. Add a custom field that is not required
  2. Try to save a user's information
    Clipboard - June 19, 2020 5_43 PM

Expected behavior:

Save without warning.

Actual behavior:

Clipboard - June 19, 2020 5_42 PM

Server Setup Information:

  • Version of Rocket.Chat Server: 3.3.0 (a987295)
  • NodeJS Version: v12.14.1
  • MongoDB Version: 3.6.18 mmapv1

Client Setup Information

  • Desktop App or Browser Version: 2.17.7
  • Operating System: Windows 10
@github-actions
Copy link
Contributor

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@github-actions github-actions bot added the stat: stale Stale issues will be automatically closed if no activity label Aug 20, 2020
@wreiske
Copy link
Contributor Author

wreiske commented Aug 20, 2020

This is still an issue in 3.5.2 be2c9fe

image

@sampaiodiego sampaiodiego added this to the 3.7.0 milestone Sep 2, 2020
@gabriellsh gabriellsh mentioned this issue Sep 8, 2020
Merged
12 tasks
@tassoevan tassoevan added stat: triaged Issue reviewed and properly tagged and removed Triaged labels Oct 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gabriellsh gabriellsh

@pierre-lehnen-rc pierre-lehnen-rc

Labels
stat: stale Stale issues will be automatically closed if no activity stat: triaged Issue reviewed and properly tagged type: bug
Projects
None yet
Milestone
3.7.0
Development

Successfully merging a pull request may close this issue.

[FIX] Custom fields required if minLength set and no text typed. RocketChat/Rocket.Chat
5 participants
@tassoevan @wreiske @sampaiodiego @gabriellsh @pierre-lehnen-rc