Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Faulty YouTube preview #3138

Closed
ghost opened this issue May 5, 2016 · 11 comments
Closed

Faulty YouTube preview #3138

ghost opened this issue May 5, 2016 · 11 comments

Comments

@ghost
Copy link

ghost commented May 5, 2016

On https://demo.rocket.chat if you paste YouTube share-link you can see different results:

https://www.youtube.com/watch?v=SWxvEbp1NjE - normal preview:
02

https://youtu.be/SWxvEbp1NjE - same video, but faulty prewiew:
01

@ghost ghost changed the title Different YouTube prewiew type:bug Faulty YouTube preview May 5, 2016
@zxweed
Copy link

zxweed commented May 6, 2016

This is ok, I don't need the big preview anytime and can choose now, please, leave this behavior.

@ghost
Copy link
Author

ghost commented May 6, 2016

This behavior is confusing ordinary users (we made a small focus group). The interface needs consistency.

@zxweed
Copy link

zxweed commented May 6, 2016

@MichaelSavin, for perfect consistency we need to disable the youtube preview, because the short preview format is default for all types of urls;

@ghost
Copy link
Author

ghost commented May 6, 2016

@zxweed I've checked in Slack - both links give full preview.
IMHO this:

  1. Consistently
  2. Follow the rules of usability - to avoid unnecessary clicks / referrals
    I have not tested the behavior in mobile- and desktop clients

@antn89
Copy link

antn89 commented May 11, 2016

Hi guy,
I install rocked.chat v 0.30, but when i send a youtube link, it doesn't show preview,
Here is config from: Rocket.Chat/programs/server/packages/rocketchat_oembed.js

providers.registerProvider({                                                                                   // 1
  urls: [new RegExp('https?://www.youtube.com/\\S+'), new RegExp('https?://youtu.be/\\S+')],                   // 33
  endPoint: 'https://www.youtube.com/oembed?maxheight=200'                                                     // 33
});

@ghost
Copy link
Author

ghost commented May 16, 2016

@marceloschmidt Please, reopen issue. In demo.rocketchat.com youtu.be links doesn't working. Try it: https://youtu.be/YlUKcNNmywk?list=RDYlUKcNNmywk

@geekgonecrazy geekgonecrazy reopened this Jun 9, 2016
@k0nsl
Copy link
Contributor

k0nsl commented Jun 9, 2016

I can confirm this and reproduce the issue; it has been like this for three or four versions back, if not more.

@geekgonecrazy geekgonecrazy added this to the Mooc milestone Jun 9, 2016
@geekgonecrazy geekgonecrazy removed this from the Mooc milestone Jul 10, 2016
@lucasvanhalst
Copy link
Contributor

lucasvanhalst commented Sep 3, 2016

Bump, this is still happening but it's worse now, no preview at all for youtu.be links.
This is the error that occurs

Exception in defer callback: SyntaxError: Unexpected end of input
     at Object.parse (native)
     at packages/rocketchat_oembed/server/providers.coffee:74:19
     at packages/rocketchat_lib/lib/callbacks.coffee:73:21
     at Array.reduce (native)
     at Object.RocketChat.callbacks.run (packages/rocketchat_lib/lib/callbacks.coffee:68:103)
     at Object.OEmbed.getUrlMeta (packages/rocketchat_oembed/server/server.coffee:135:30)
     at Object.OEmbed.getUrlMetaWithCache (packages/rocketchat_oembed/server/server.coffee:148:16)
     at packages/rocketchat_oembed/server/server.coffee:195:18
     at Array.forEach (native)
     at OEmbed.RocketUrlParser (packages/rocketchat_oembed/server/server.coffee:184:16)

version 072c5b0

@maxdwit
Copy link

maxdwit commented Jan 27, 2017

In Version 0.50.1 still an issue http://youtu.be/SWxvEbp1NjE
Short youtu.be links fail to preview

@maxdwit
Copy link

maxdwit commented Jun 15, 2017

In Version 0.51.0 still no preview for youtu.be Links.

@geekgonecrazy
Copy link
Contributor

Its working on demo server on 0.57.0-rc.2 i'll go ahead and close this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants