Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Admin can remove user even if user is already removed from the room #31712

Closed
shivang-16 opened this issue Feb 9, 2024 · 6 comments · Fixed by #31525
Closed

Admin can remove user even if user is already removed from the room #31712

shivang-16 opened this issue Feb 9, 2024 · 6 comments · Fixed by #31525

Comments

@shivang-16
Copy link
Contributor

shivang-16 commented Feb 9, 2024

Description:

When an admin removes a user from a room, the option to remove the user persists for the admin, even after the user has been successfully removed. This creates confusion and a potential for unintended actions.

Steps to reproduce:

  1. Log in to Rocket.Chat as an administrator.
  2. Navigate to a specific room where multiple users are present.
  3. Remove a user from the room.
  4. Verify that the user has been successfully removed from the room.
  5. Observe that the option to remove the same user is still available for the admin.

Expected behavior:

The option to remove a user should not be available for the admin after the user has been successfully removed from the room. This ensures clarity and prevents unintentional actions.

Actual behavior:

The option to remove the user persists for the admin even after successfully removing the user from the room.

Server Setup Information:

  • Version of Rocket.Chat Server: 6.7.0
  • Operating System: macOS
  • NodeJS Version: 14.21.3
  • MongoDB Version: 6.0.3

Client Setup Information

  • Desktop App or Browser Version: chrome 121
  • Operating System: macOs

Pull request corresponds to this issue

#31525

Additional context

b19b-a791-41d7-9195-02b0e5c78af7.mp4
@shivang-16
Copy link
Contributor Author

hey @dougfabris @rique223, should I work on this issue?

@rique223
Copy link
Contributor

rique223 commented Feb 9, 2024

Please have at it @shivang-16, this looks like a big UX issue.

@shivang-16
Copy link
Contributor Author

okay sure, I'm working on this

@rique223
Copy link
Contributor

rique223 commented Feb 9, 2024

Hey @shivang-16, looks like we already have a PR that solves this issue. Could you please have a look at #31525 and close this issue if the problem is already solved?

@shivang-16
Copy link
Contributor Author

yeah @rique223 , I think the problem is solve in that pr. Should I close this issue or you can link that issue with the pr?

@rique223
Copy link
Contributor

rique223 commented Feb 9, 2024

@shivang-16 Please link it to the PR, it was a little mistake on my side telling you to close it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants