Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Limit @ user list to members of private room #7489

Closed
danieljhochman opened this issue Jul 13, 2017 · 10 comments · Fixed by #7830
Closed

Limit @ user list to members of private room #7489

danieljhochman opened this issue Jul 13, 2017 · 10 comments · Fixed by #7830
Assignees

Comments

@danieljhochman
Copy link

If I have a private room and try to @ someone, the users which appear in the list should be limited to the members of that private room.

@danieljhochman
Copy link
Author

@Sing-Li - this is not a show stopper for us (for pahse 1) but seems like an important bug to fix

@geekgonecrazy
Copy link
Contributor

Related/Duplicate #2588

@localguru
Copy link
Contributor

localguru commented Jul 19, 2017

+1 I think this makes sense, because in contrast to channels you can't add an user by @username to a private room.

@Chris-Duke
Copy link

I actually quite like the fact you can @ other people in a private room. If you're talking about someone specifically, it's good to be able to show someone who you're talking about so the other person you're talking to can click on that linked persons profile, for example and grab their e-mail address/details.

@danieljhochman
Copy link
Author

@ing other people is fine. Showing members in the auto-complete who are not in the private room, is not correct. Look how Slack does it.

@geekgonecrazy
Copy link
Contributor

Here it seems like privacy by default would be best. Maybe allow it to be overrode to show all via permission

@danieljhochman
Copy link
Author

@geekgonecrazy - what's the use-case for showing non-members in a private room? Why even make it a setting?

@geekgonecrazy
Copy link
Contributor

The main use case would be so that people that like to refer to people outside the room still can. But by default it wouldn't be possible.

Also wouldn't be a setting. Lets say for instance the permission is on admin. Admin could see and mention anyone.

If you decided to set your server up so your staff can see others on the server but guests you invite in (lets say clients) are not. You would simply assign the guest a role with out the permission to view / mention users not in group.

Not saying this is how it will be implemented. Just saying this is what would be most flexible. The developer that takes this will ultimately be the one to decide.

A permission could always be added later if people missed being able to mention.

@JSzaszvari
Copy link
Contributor

Why not just seperate the list into


Users of this channel

x
x
x
x


Users not in this channel

x
x
x
x

And have the priority autocomplete be the people in the room.

@geekgonecrazy
Copy link
Contributor

@JSzaszvari because of privacy primarily. :) The few i've talked to that want this want to invite their clients to a private group and them not be able to use autocomplete and accidentally see other clients.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants