Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] [UI] Some padding and margin issue with new design in RTL layout #7821

Closed
mnlbox opened this issue Aug 21, 2017 · 6 comments
Closed

[BUG] [UI] Some padding and margin issue with new design in RTL layout #7821

mnlbox opened this issue Aug 21, 2017 · 6 comments
Assignees
Milestone

Comments

@mnlbox
Copy link

mnlbox commented Aug 21, 2017

@MartinSchoeler I have 3 issue with new design ( #7643 ) in RTL layout I describe these issues based on below image:

  1. Extra space between side menu and page content. Because this extra space some of content not visible.
  2. menu items needs some padding or margin from right but it's not available now.
  3. Username also need some padding or margin from right but it's not available now.

All of these works well with previous design and breaks in new design 😢
rtl issue

Server Setup Information:

  • Version of Rocket.Chat Server: 0.59.0-develop
  • Operating System: linux
  • Deployment Method(snap/docker/tar/etc): -
  • Number of Running Instances:
  • DB Replicaset Oplog: Enabled
  • Node Version: 4.8.4 - x64
@mnlbox
Copy link
Author

mnlbox commented Aug 26, 2017

Guys any update about this?
Many users use RTL language and now new design break app. 😢
I can't see save button almost in any form because of this extra padding (number 1 in above image)

/CC: @MartinSchoeler , @karlprieb , @sampaiodiego , @gdelavald

@gdelavald
Copy link
Contributor

@mnlbox hey, this will be fixed for the next Release Candidate. Thanks for your patience.

@mnlbox
Copy link
Author

mnlbox commented Aug 28, 2017

See this for more detail:
7821

@rodrigok rodrigok modified the milestones: 0.59.0-rc.3, 0.59.0 Aug 28, 2017
@karlprieb karlprieb self-assigned this Aug 29, 2017
@rodrigok rodrigok modified the milestones: 0.59.0-rc.3, 0.59.0-rc.4 Aug 31, 2017
@gdelavald gdelavald modified the milestones: 0.59.0-rc.5, 0.59.0-rc.4 Sep 4, 2017
@cyclops24
Copy link
Contributor

@karlprieb are you still working on this?

@gdelavald
Copy link
Contributor

@cyclops24 feel free to create a branch and submit a PR for this.

@ggazzo
Copy link
Member

ggazzo commented Sep 14, 2017

closed by #8112

@ggazzo ggazzo closed this as completed Sep 14, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

8 participants