Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] [UI] Some bug in create room modal in RTL #8186

Closed
cyclops24 opened this issue Sep 18, 2017 · 3 comments · Fixed by #8194 or #8278
Closed

[BUG] [UI] Some bug in create room modal in RTL #8186

cyclops24 opened this issue Sep 18, 2017 · 3 comments · Fixed by #8194 or #8278
Assignees
@karlprieb
Labels
type: bug
Milestone
0.59.0-rc.9

Comments

@cyclops24
Copy link
Contributor

Hey guys,
I found this bug in a chat with @ggazzo I think @karlprieb can join us here to solve this.
12
@cyclops24 cyclops24 mentioned this issue Sep 18, 2017
Closed
4 tasks
@gdelavald gdelavald added this to the 0.59.0-rc.6 milestone Sep 18, 2017
@engelgabriel engelgabriel changed the title [BIG] [UI] Some bug in create room modal in RTL [BUG] [UI] Some bug in create room modal in RTL Sep 18, 2017
@karlprieb karlprieb mentioned this issue Sep 18, 2017
Merged
@rodrigok rodrigok modified the milestones: 0.59.0-rc.6, 0.59.0-rc.7 Sep 19, 2017
@cyclops24
Copy link
Contributor Author

This is also another alignment issue about this page:
01

@cyclops24
Copy link
Contributor Author

@karlprieb , @rodrigok Cross icon to cancel button on modal still has bug in Firefox 55:
16
Other parts fixed completely, thanks @karlprieb 😉

@rodrigok rodrigok reopened this Sep 22, 2017
@engelgabriel
Copy link
Member

Part of #8175

@cyclops24 cyclops24 mentioned this issue Sep 24, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@karlprieb karlprieb

Labels
type: bug
Projects
None yet
Milestone
0.59.0-rc.9
Development

Successfully merging a pull request may close this issue.

Fix more rtl issues RocketChat/Rocket.Chat
[FIX] "Cancel button" on modal in RTL in Firefox 55
5 participants
@rodrigok @engelgabriel @gdelavald @cyclops24 @karlprieb