Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] [i18n] "Members List" online users count not avaiable in RTL #8201

Closed
cyclops24 opened this issue Sep 19, 2017 · 6 comments
Closed

[BUG] [i18n] "Members List" online users count not avaiable in RTL #8201

cyclops24 opened this issue Sep 19, 2017 · 6 comments
Milestone

Comments

@cyclops24
Copy link
Contributor

Hi,
@karlprieb in "Members List" tab, online users count not avaiable in RTL. See below images for more info.
Here in LTR (English) we have 3 value (green line: showing count, blue line: online count, orange line: total count)
13
But in RTL we just have 2 value (green line: showing count, orange line: total count) and we miss online count
14

@gdelavald
Copy link
Contributor

This issue will be moved to release 0.60 since the UI Redesign will change most of the sidebar layout.

@cyclops24
Copy link
Contributor Author

@gdelavald It's not related to UI it's a i18n bug about Showing_online_users key. 😉
I try to fix it.

@cyclops24 cyclops24 changed the title [BUG] [UI] "Members List" online users count not avaiable in RTL [BUG] [i18n] "Members List" online users count not avaiable in RTL Sep 23, 2017
@engelgabriel engelgabriel modified the milestones: 0.60.0, 0.59.0-rc.9 Sep 23, 2017
@karlprieb
Copy link
Contributor

Hey @cyclops24 it's a translate problem :( Can you help us making a PR with the right translation? It's the Showing_online_users key.

In en_US we use three parameters on this key "Showing_online_users": "Showing: <b>__total_showing__</b>, Online: __online__, Total: __total__ users", in ar instead we are using only two paramenters "Showing_online_users": "معروض <b>__total_showing__</b> من __total__ عضو"

@cyclops24
Copy link
Contributor Author

Hi @karlprieb, Yes I can provide PR for it. 😉

@rodrigok rodrigok modified the milestones: 0.59.0-rc.9, 0.59.0-rc.10 Sep 26, 2017
@cyclops24
Copy link
Contributor Author

Part of #8175

@cyclops24
Copy link
Contributor Author

@karlprieb I fix it in lingohub. Can you check it there?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants