Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] [i18n] "Create Channel" modal placeholders not translatable #8268

Closed
cyclops24 opened this issue Sep 23, 2017 · 2 comments · Fixed by #8269
Closed

[BUG] [i18n] "Create Channel" modal placeholders not translatable #8268

cyclops24 opened this issue Sep 23, 2017 · 2 comments · Fixed by #8269
Milestone
0.59.0-rc.9

Comments

@cyclops24
Copy link
Contributor

cyclops24 commented Sep 23, 2017 •
edited
Loading

Hi guys,
Channel name placeholder not translatable. See this line (placeholder="Type channel name")

/CC: @karlprieb , @rodrigok , @ggazzo
@cyclops24 cyclops24 mentioned this issue Sep 23, 2017
Closed
4 tasks
@cyclops24
Copy link
Contributor Author

"username" at in this line (placeholder="{{_ "username"}}") also not contain value and this key not exist in en.i18n.json file.

@cyclops24 cyclops24 changed the title [BUG] [i18n] Channel name placeholder not translatable [BUG] [i18n] "Create Channel" modal placeholders not translatable Sep 23, 2017
@cyclops24 cyclops24 mentioned this issue Sep 23, 2017
Merged
@engelgabriel engelgabriel added this to the 0.59.0-rc.9 milestone Sep 23, 2017
@engelgabriel
Copy link
Member

Part of #8175

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.59.0-rc.9
Development

Successfully merging a pull request may close this issue.

[FIX] some placeholder and phrase traslation fix
2 participants
@engelgabriel @cyclops24