Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Custom Emojis are cropped instead of scaled. #9643

Closed
jselleck opened this issue Feb 8, 2018 · 0 comments · Fixed by #9676
Closed

Custom Emojis are cropped instead of scaled. #9643

jselleck opened this issue Feb 8, 2018 · 0 comments · Fixed by #9676

Comments

@jselleck
Copy link

jselleck commented Feb 8, 2018

Description:

When adding custom emojis of varying widths/heights the image is cropped in the message pain as well as selection.

Server Setup Information:

  • Version of Rocket.Chat Server: 0.60.4
  • Operating System: Windows 10
  • Deployment Method(snap/docker/tar/etc): docker
  • Number of Running Instances: 1
  • DB Replicaset Oplog:
  • Node Version:

Steps to Reproduce:

  1. Add Custom Emoji. - I.E. try with this image: https://www.google.com/search?q=meme&source=lnms&tbm=isch&sa=X&ved=0ahUKEwjVzuaG69zWAhXk4IMKHTg5DRsQ_AUICigB&biw=1050&bih=643#imgrc=j_PXxZSMSZSELM:
  2. Try to use in chat.
  3. Notice top and bottom are cropped.

Expected behavior:

The image should be scaled but should maintain aspect ratio. The entire image should be seen.

Actual behavior:

The image is cropped.

image

image
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[FIX] Custom emoji was cropping sometimes anu-007/Rocket.Chat
1 participant
@jselleck