From 316b358cfbb7ecb3aa9c9cd0f9b62a53551e0e80 Mon Sep 17 00:00:00 2001 From: Felipe Parreira Date: Wed, 16 Sep 2020 15:35:55 -0300 Subject: [PATCH 1/2] fix(ufs-proxy): correct routing pattern --- app/file-upload/server/lib/proxy.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/app/file-upload/server/lib/proxy.js b/app/file-upload/server/lib/proxy.js index 8aaff7ce7088..c32229c2ea32 100644 --- a/app/file-upload/server/lib/proxy.js +++ b/app/file-upload/server/lib/proxy.js @@ -15,7 +15,7 @@ WebApp.connectHandlers.stack.unshift({ route: '', handle: Meteor.bindEnvironment(function(req, res, next) { // Quick check to see if request should be catch - if (req.url.indexOf(UploadFS.config.storesPath) === -1) { + if (!req.url.includes(`/${ UploadFS.config.storesPath }/`)) { return next(); } From 938d02f299aebbb366fd2eee6c927db2b9a72e24 Mon Sep 17 00:00:00 2001 From: Felipe Parreira Date: Wed, 16 Sep 2020 15:49:33 -0300 Subject: [PATCH 2/2] chore(ufs-proxy): add deprecation console warning --- app/file-upload/server/lib/proxy.js | 1 + 1 file changed, 1 insertion(+) diff --git a/app/file-upload/server/lib/proxy.js b/app/file-upload/server/lib/proxy.js index c32229c2ea32..0921956d111a 100644 --- a/app/file-upload/server/lib/proxy.js +++ b/app/file-upload/server/lib/proxy.js @@ -84,6 +84,7 @@ WebApp.connectHandlers.stack.unshift({ method: 'POST', }; + console.warn('UFS proxy middleware is deprecated as this upload method is not being used by Web/Mobile Clients. See this: https://docs.rocket.chat/api/rest-api/methods/rooms/upload'); const proxy = http.request(options, function(proxy_res) { proxy_res.pipe(res, { end: true,