From 4947ced1a6e10a541b6aa7e59e90127ab8c1a8d9 Mon Sep 17 00:00:00 2001 From: laurapgp <69488779+laurapgp@users.noreply.github.com> Date: Wed, 9 Oct 2024 15:51:29 +0200 Subject: [PATCH 1/2] BUG: fix zero mass check --- rocketpy/motors/motor.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/rocketpy/motors/motor.py b/rocketpy/motors/motor.py index eae7931b4..5fa154d88 100644 --- a/rocketpy/motors/motor.py +++ b/rocketpy/motors/motor.py @@ -370,7 +370,7 @@ def dry_mass(self, dry_mass): dry_mass : float Motor dry mass in kg. """ - if dry_mass: + if dry_mass is not None: if isinstance(dry_mass, (int, float)): self._dry_mass = dry_mass else: From eb3ad14d1c0f43b43ab06a021fdc69249be4abe0 Mon Sep 17 00:00:00 2001 From: Pedro Bressan Date: Wed, 9 Oct 2024 20:53:30 +0200 Subject: [PATCH 2/2] MNT: Add bug zero dry mass bug fix to CHANGELOG. --- CHANGELOG.md | 1 + 1 file changed, 1 insertion(+) diff --git a/CHANGELOG.md b/CHANGELOG.md index 1dc1e850a..ba1d36558 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -50,6 +50,7 @@ Attention: The newest changes should be on top --> ### Fixed +- BUG: Fix Motor Zero Dry Mass Check [#710](https://github.com/RocketPy-Team/RocketPy/pull/710) - BUG: Fix Environment.max_expected_height for custom atmosphere [#707](https://github.com/RocketPy-Team/RocketPy/pull/707) - BUG: Initialize _Controller Init Parameters [#703](https://github.com/RocketPy-Team/RocketPy/pull/703) - BUG: Rail Buttons Not Accepted in Add Surfaces [#701](https://github.com/RocketPy-Team/RocketPy/pull/701)