From 2aa66d18495dbc9af41eea75bcd3d52b6e7286d2 Mon Sep 17 00:00:00 2001
From: Struan Clark <xtruan@gmail.com>
Date: Sun, 12 Mar 2023 19:01:53 -0600
Subject: [PATCH] write QR codes for addresses to file - cleanup

---
 application.fam         |  2 +-
 views/flipbip_scene_1.c | 13 +++++++------
 2 files changed, 8 insertions(+), 7 deletions(-)

diff --git a/application.fam b/application.fam
index c539e9b0b8a..d0fb99272f6 100644
--- a/application.fam
+++ b/application.fam
@@ -7,7 +7,7 @@ App(
     requires=[
         "gui",
     ],
-    stack_size=2 * 1024,
+    stack_size=3 * 1024,
     order=10,
     fap_icon="flipbip_10px.png",
     fap_icon_assets="icons",
diff --git a/views/flipbip_scene_1.c b/views/flipbip_scene_1.c
index 1d285e8644a..f1ddec4f347 100644
--- a/views/flipbip_scene_1.c
+++ b/views/flipbip_scene_1.c
@@ -389,7 +389,7 @@ static int flipbip_scene_1_model_init(
 
     // buffer for key serialization
     const size_t buflen = 128;
-    char buf[128 + 1];
+    char buf[128 + 1] = {0};
 
     // coin info
     // bip44_coin, xprv_version, xpub_version, addr_version, wif_version, addr_format
@@ -452,12 +452,13 @@ static int flipbip_scene_1_model_init(
         flipbip_scene_1_init_address(model->recv_addresses[a], node, coin_info[5], a);
 
         // Save QR code file
-        char name[14] = {0};
-        strcpy(name, COIN_TEXT_ARRAY[coin][0]);
+        memzero(buf, buflen);
+        strcpy(buf, COIN_TEXT_ARRAY[coin][0]);
         const unsigned char addr_num[1] = {a};
-        flipbip_btox(addr_num, 1, name + strlen(name));
-        strcpy(name + strlen(name), TEXT_QRFILE_EXT);
-        flipbip_save_qrfile(COIN_TEXT_ARRAY[coin][2], model->recv_addresses[a], name);
+        flipbip_btox(addr_num, 1, buf + strlen(buf));
+        strcpy(buf + strlen(buf), TEXT_QRFILE_EXT);
+        flipbip_save_qrfile(COIN_TEXT_ARRAY[coin][2], model->recv_addresses[a], buf);
+        memzero(buf, buflen);
     }
 
     model->page = PAGE_INFO;