Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add overload for TransformMany to support IObservableList #193

Conversation

ronaldvdv
Copy link

  • Added an extra constructor in TransformMany that accepts a Func<TParent, IObservableList<TChild>> as its manyselector. Since we want to be able to call the original manyselector again when the parent is removed (instead of remembering the value of manyselector(x).Items when the parent was added), I also added a small ManySelectorFunc class that captures the original selector.
  • Added an overload of the TransformMany extension method too
  • Duplicated and fixed the unit test for TransformMany to also test the new overloads

@ronaldvdv
Copy link
Author

Solves #158

@RolandPheasant RolandPheasant merged commit 4b16e0a into reactivemarbles:master Jan 10, 2019
@RolandPheasant
Copy link
Collaborator

Thanks for this. I will leave the issue open as I will add some optimisations. Additionally I will add the same operator for the cache side of dd

@ronaldvdv
Copy link
Author

Sounds good, thanks!

@lock lock bot locked and limited conversation to collaborators Jul 9, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants