Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor redefined multiple times Error #2436

Open
3 tasks
MahadMuhammad opened this issue Jul 17, 2023 · 0 comments
Open
3 tasks

Refactor redefined multiple times Error #2436

MahadMuhammad opened this issue Jul 17, 2023 · 0 comments
Assignees

Comments

@MahadMuhammad
Copy link
Contributor


Refactor Redefined multiple times Error function into one error function

  • Creating error code class
  • Refactoring rust_error_at function.
  • Passing appropriate error code from that function
    • This is because rustc emit different error code for struct , ... etc.,

It's worth refactoring that error function, as it has almost exact same error message and pattern.

➜  gccrs git:(master) ack  'redefined multiple times'
gcc/rust/resolve/rust-ast-resolve-type.h
183:		       "generic param redefined multiple times");

gcc/rust/resolve/rust-ast-resolve-implitem.h
63:	rust_error_at (r, "redefined multiple times");
79:	rust_error_at (r, "redefined multiple times");
96:	rust_error_at (r, "redefined multiple times");
112:	rust_error_at (r, "redefined multiple times");
152:	rust_error_at (r, "redefined multiple times");
172:	rust_error_at (r, "redefined multiple times");
192:	rust_error_at (r, "redefined multiple times");
210:	rust_error_at (r, "redefined multiple times");
250:	rust_error_at (r, "redefined multiple times");
269:	rust_error_at (r, "redefined multiple times");

gcc/rust/resolve/rust-ast-resolve-toplevel.h
61:	rust_error_at (r, "redefined multiple times");
91:	rust_error_at (r, "redefined multiple times");
113:	rust_error_at (r, "redefined multiple times");
135:	rust_error_at (r, "redefined multiple times");
161:	rust_error_at (r, "redefined multiple times");
183:	rust_error_at (r, "redefined multiple times");
205:	rust_error_at (r, "redefined multiple times");
227:	rust_error_at (r, "redefined multiple times");
251:	rust_error_at (r, "redefined multiple times");
273:	rust_error_at (r, "redefined multiple times");
293:	rust_error_at (r, "redefined multiple times");
314:	rust_error_at (r, "redefined multiple times");
336:	rust_error_at (r, "redefined multiple times");
380:	rust_error_at (r, "redefined multiple times");
400:	rust_error_at (r, "redefined multiple times");
476:	rust_error_at (r, "redefined multiple times");

gcc/rust/resolve/rust-ast-resolve-expr.cc
428:	  rust_error_at (label.get_locus (), "label redefined multiple times");
502:	  rust_error_at (label.get_locus (), "label redefined multiple times");
531:	  rust_error_at (label.get_locus (), "label redefined multiple times");

gcc/rust/resolve/rust-ast-resolve-stmt.h
65:	rust_error_at (r, "redefined multiple times");
100:	rust_error_at (r, "redefined multiple times");
133:	rust_error_at (r, "redefined multiple times");
165:	rust_error_at (r, "redefined multiple times");
185:	rust_error_at (r, "redefined multiple times");
211:	rust_error_at (r, "redefined multiple times");
237:	rust_error_at (r, "redefined multiple times");
258:	rust_error_at (r, "redefined multiple times");
296:	rust_error_at (r, "redefined multiple times");
332:	rust_error_at (r, "redefined multiple times");

gcc/testsuite/rust/compile/redef_error5.rs
5:    const TEST: bool = false; // { dg-error "redefined multiple times"  }

gcc/testsuite/rust/compile/redef_error4.rs
12:    fn test() -> bool { // { dg-error "redefined multiple times" }

gcc/testsuite/rust/compile/redef_error3.rs
5:fn test() -> i32 { // { dg-error "redefined multiple times" }

gcc/testsuite/rust/compile/redef_error1.rs
6:struct S1(i32, bool); // { dg-error "redefined multiple times" }

gcc/testsuite/rust/compile/redef_error6.rs
8:    fn test(self) -> i32 { // { dg-error "redefined multiple times" }

gcc/testsuite/rust/compile/redef_error2.rs
2:const TEST: f32 = 3.0; // { dg-error "redefined multiple times" }
@MahadMuhammad MahadMuhammad changed the title Refactor Redefined multiple times Error Refactor redefined multiple times Error Jul 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant