Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document the behavior for multiplexed ogg files #86

Open
TonalidadeHidrica opened this issue Nov 7, 2020 · 1 comment · May be fixed by #94
Open

Document the behavior for multiplexed ogg files #86

TonalidadeHidrica opened this issue Nov 7, 2020 · 1 comment · May be fixed by #94

Comments

@TonalidadeHidrica
Copy link

The Vorbis specification states that an ogg/vorbis file may contain chained Vorbis stream, but may not be multiplexed.
When a new logical stream starts without the previous stream ends, the current lewton decoder switches to the new stream and discards the remainder of previous stream. Although handling such situation is not required by the situation, it may be better to document the behavior. Also, it may be ideal that users can handle multiplexed stream individually.

@TonalidadeHidrica
Copy link
Author

On the other hand, we may simply deny the entire parsing once we encountered a multiplexed stream (return Err after we found the beginning of another stream before the previous stream ends). This behavior is consistent with read_headers, which only accepts three headers aligned in row.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant