Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot use call about endpoint when the LRS supports an unknown version of xAPI #26

Open
madmox opened this issue Feb 20, 2017 · 0 comments
Labels

Comments

@madmox
Copy link
Contributor

madmox commented Feb 20, 2017

We use the ADL LRS for testing purposes. I started to write unit tests to validate a set of functionality and stumbled accross this problem in my 1st test:

var lrs = new RemoteLRS("https://lrs.adlnet.gov/xAPI/", "<username>", "<password>");
AboutLRSResponse about = this._lrs.About(); // throws exception

The problem is that the LRS returns a json containing this list of versions: "version": ["1.0.0", "1.0.1", "1.0.2", "1.0.3"], and the .NET client tries to map each of them to a known hard coded version, although it does not yet "know" the version 1.0.3! (deserialization exception when executing version.Add((TCAPIVersion)item);)

Other related issue: TCAPIVersion.latest() currently returns 1.0.1, although 1.0.2 is in the supported versions list. In my opinion, TCAPIVersion.latest() should return the latest entry in the supported list, and the supported list should or should not include 1.0.2, depending on the state of your implementation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants