Adding proxy parameters if necessary

[deedey]

If your Moodle server is behind a proxy server, you have to add a parameter ad-hoc like this:

    _$http = array(
        //
        // redirects are not part of the spec so LRSs shouldn't be returning them
        //
        'max_redirects' => 0,
        //
        // this is here for some proxy handling
        //
        'request_fulluri' => 1,
        **'proxy'   => '192.168.100.XXX:8080',**
        //
        // switching this to false causes non-2xx/3xx status codes to throw exceptions
        // but we need to handle the "error" status codes ourselves in some cases
        //
        'ignore_errors' => true,
        'method' => $method,
        'header' => array(
            'X-Experience-API-Version: ' . $this->version
        ),
    );_

[nadavkav]

Just came accros the same issue with Moodle using the "xAPI LogStore" plugin (that uses this code/library)

Thanks for the suggested fix. it helped 😄

I suggest improving the library code to support initiating the class with a new optional proxy param
so Moodle and other projects can propagate their proxy settings.

[ryasmi]

@garemoko any idea when this might be addressed?

[garemoko]

@ryansmith94 no, but certainly sooner if somebody makes a PR. :-)

@deedey @nadavkav does one of you want to take this on?

[deedey]

@garemoko, @ryansmith94
@nadavkav has launched a same subject in moodle-logstore_xapi.
I think we can close this one, if you agree.

[nadavkav]

I will upload a PR, soon

[nadavkav]

@deedey Please do not close this one, as it is a dependancy to a fix I will also upload to moodle-logstore_xapi , later on.

[deedey]

As you like ,@nadavkav.

[ryasmi]

Yeah I agree with @nadavkav, there is work to be completed in both repos so we need to keep the issues open and close them separately when the work is completed.

[nadavkav]

Thanks

[deedey]

Thank you @brianjmiller @nadavkav
It work fine now in moodle-logstore_xapi with your both changes.
The proxy parameters are now recognized automaticly
Great thanks

[nadavkav]

Super cool 😄