Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Does it ever make sense to delete attributes? #76

Open
chaimleib opened this issue Jun 27, 2014 · 3 comments
Open

Does it ever make sense to delete attributes? #76

chaimleib opened this issue Jun 27, 2014 · 3 comments
Labels

Comments

@chaimleib
Copy link

If not, should we remove the deleters, and make all attributes behave as 'required'?

-> If so, should we change the meaning of _props_req and _props?

@brianjmiller
Copy link
Member

What does the word "delete" mean in this case? If it is more akin to 'unset' or setting to undefined/null equivalent then that is certainly valid. If it means this object does not have a particular attribute anymore then it doesn't.

@chaimleib
Copy link
Author

The second one. Trying to access a deleted attribute will result in an AttributeError

@brianjmiller
Copy link
Member

Then 👍 to getting rid of deleters, don't think there is ever a case where an attribute should be removed. Presumably they would set to None if they need to "clear" a value which would be common. I don't think need to change _props and _props_req as the 'req' there is more akin to 'required' by the LRS for valid object (at least I think, feel free to correct if wrong).

Want to do the work?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants