Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor Time to match Fiori 3 specs and the sap-theming #577

Closed
InnaAtanasova opened this issue Jan 7, 2020 · 0 comments · Fixed by #801
Closed

Refactor Time to match Fiori 3 specs and the sap-theming #577

InnaAtanasova opened this issue Jan 7, 2020 · 0 comments · Fixed by #801
Assignees

Comments

@InnaAtanasova
Copy link
Contributor

InnaAtanasova commented Jan 7, 2020

Refactor Time to match Fiori 3 specs and the sap-theming

!!! Rename to Time Picker !!!

  • For the colors, remove all occurrences of hard-coded values and replace them with the corresponding values from @sap-theming
  • Where possible, use css variables from @sap-theming for the borders, border-radius, font-size, font-family, etc.
  • Update the paddings, margins, font-sizes, line-heights, etc to match 100% the Fiori 3 specs
  • If necessary, rename the component and its classes accordingly
  • Update the project Playground tests if necessary and test the component. See here more information about how to run the development Playground
  • Update the visual regression tests
  • Test the component in all browsers (cross-browser support)
  • a11y
  • Document the Breaking Changes
  • Provide a detailed description of the changes that are made in the Pull Request and attach screenshots with Before and After
  • In the Pull Request link to the related issue see the PR Guidelines

Please refer to the following links for more information about the project:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants