Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CartesianGrid2D not having magnitude attribute instantiation #257

Open
pabloitu opened this issue Jul 18, 2024 · 0 comments
Open

CartesianGrid2D not having magnitude attribute instantiation #257

pabloitu opened this issue Jul 18, 2024 · 0 comments
Assignees

Comments

@pabloitu
Copy link
Collaborator

The class, representing a region, do not have a explicit self.magnitude attribute. However, this attribute is called in some occasions. For example, in

mag_bins = self.region.magnitudes

In predetermined regions, the attributed is hard-coded into the CartesianGrid2D class.

relm_region.magnitudes = magnitudes

which also should be part of the workflow of the modeler. However, CartesianGrid2D.magnitudes should be declared at the class init, and have the possibility to be declared when instantiating.

@pabloitu pabloitu self-assigned this Jul 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant