Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build status/link #587

Closed
janisozaur opened this issue Jul 11, 2016 · 4 comments
Closed

Build status/link #587

janisozaur opened this issue Jul 11, 2016 · 4 comments
Labels
bug Behaving differently as it should behave documentation Involves the project documentation good first issue Suitable for newcomers just do it You can start working on this, there should be nothing left to discuss

Comments

@janisozaur
Copy link
Contributor

janisozaur commented Jul 11, 2016

https://github.com/SFTtech/openage/blob/8f3fbf81c11e3503ff688fbd4d30df3917e89721/doc/code/testing.md

Mentions:

All tests are run automatically by Travis, via python3 -m openage.testing -a.

But travis was replaced with kevin.

Independent of this issue: There's also no link/badge pointing to most recent kevin build in readme.md.

@TheJJ TheJJ added bug Behaving differently as it should behave documentation Involves the project documentation good first issue Suitable for newcomers just do it You can start working on this, there should be nothing left to discuss labels Jul 11, 2016
@zuntrax
Copy link
Contributor

zuntrax commented Jul 12, 2016

Kevin runs the sanity check with make checkall.

AFAIK, kevin does not yet support badges, but generating one probably boils down to a bunch of imagemagick calls. However, a badge is kind of pointless without a decent web interface. Last time I started looking into it, a ragequit occured because npm (needed for Ember.js) was cumbersome on my distro of choice. Maybe it's time to try that again.

@janisozaur
Copy link
Contributor Author

janisozaur commented Jul 12, 2016

Have you seen http://shields.io/ ?

kevin

@TheJJ
Copy link
Member

TheJJ commented Jul 13, 2016

Heh :)
The "true" approach is a badge action in kevin, which generates a symlink to the correct badge in the build folder. But so far I didn't have time/motivation for implementing that in kevin.

@TheJJ
Copy link
Member

TheJJ commented Jan 10, 2017

This was fixed in 039b196. The kevin badge is still missing, but that is something for SFTtech/kevin#11.

@TheJJ TheJJ closed this as completed Jan 10, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Behaving differently as it should behave documentation Involves the project documentation good first issue Suitable for newcomers just do it You can start working on this, there should be nothing left to discuss
Projects
None yet
Development

No branches or pull requests

3 participants