Add support for Theme upload #9

aayushdutt · 2019-06-27T18:01:43Z

Due to the Ephimeral file system of Heroku, currently the admin panel doesn't support uploading the themes directly. If uploaded, the theme would go missing after some time. The only way to use custom theme currently is to commit your themes in the code files and then re publish the application.
It would be good if we could add support for theme upload directly via the admin panel.

SNathJr · 2019-06-28T18:37:36Z

Yes, you are absolutely right about the theme uploading issue. If you need to use this feature, I would recommend using AWS S3 as your file storage while building the application. I am still working on a viable way to enable theme uploads for free. If you have any service in mind, do share. Thank you.

aayushdutt · 2019-06-28T18:42:40Z

Integrating Cloud Storage could be a good option.

SNathJr · 2019-06-30T09:01:54Z

Thank you. It looks promising. I will test it's integration with heroku in near future.

aayushdutt · 2019-07-13T14:58:57Z

Are you sure that in case of S3/Cloud Storage, the uploaded theme will not be stored in the file system?
I guess S3 integration docs says it only serves the images

SNathJr · 2019-08-13T11:43:38Z

@aayushdutt My bad, I just verified that it does not support themes upload. I am looking into the Ghost-Storage-Base repository to make a storage adapter with themes storage enabled.

codechair · 2020-01-22T11:59:17Z

Voting for this enhancement 👍🏼

SNathJr · 2020-01-23T18:43:58Z

@codechair I still have not found a viable solution to this. Things either require paid subscriptions or do not support files other than static images.
However, I will still be looking for other solutions (also considering to create a custom driver that syncs from remote on restart - such as a github private repo dump. But unless otherwise motivated, this will take time.)

stale · 2020-01-30T19:29:08Z

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

xjose97x · 2020-02-03T21:38:22Z

Things either require paid subscriptions or do not support files other than static images.

S3 supports any file types. Not only images.

SNathJr · 2020-02-07T02:00:47Z

Hey @xjose97x S3 does support all file types, however it requires you to have a paid AWS subscription, which many do not have.

S3 adapter of Ghost however does not seem to have support for storing themes on to S3, it just puts them in local storage.

BadBrahmin · 2020-02-09T12:15:23Z

Is this issue also the reason my gatsby + netlify deployment shows the default theme while my Heroku deployment shows the active theme?

stale · 2020-02-16T13:42:58Z

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

dwanderton · 2020-03-26T05:43:56Z

+1

jerinjacob1999 · 2020-04-16T14:10:06Z

You can clone a theme in local and edit as needed, push it to GitHub, and change the theme URL on the package.json file to your GitHub theme repo. Finally, deploy on Heroku.

"casper": "github:jerinjacob1999/Casper",

stephenajulu · 2020-04-28T07:36:47Z

Great support @SNathJr
Good job for this.
I am using your button to build a ghost headless cms gatsby powered site.
Working on it now.

vyronarediano · 2020-05-01T07:21:55Z

"uploading the themes directly. If uploaded, the theme would go missing after some time. "

I also encountered this. Does anyone know how to solve this? Is there any workaround for this?

Thanks in advance.

jerinjacob1999 · 2020-05-01T07:35:22Z

You can clone a theme in local and edit as needed, push it to GitHub, and change the theme URL on the package.json file to your GitHub theme repo. Finally, deploy on Heroku.

"casper": "github:jerinjacob1999/Casper",

@vyronarediano

vyronarediano · 2020-05-01T14:43:01Z

Hello @aayushdutt,

What should be the value of my theme?

and as you said "Clone it and copy your theme in content/themes" - Is this in zip file format? or the extracted one? because upon uploading it in content/themes there were no changes to push.
Only when I edit the package.json and copytheme.sh.

Many thanks in advance.

aayushdutt · 2020-05-01T23:54:48Z

@vyronarediano You should copy the extracted contents inside contents/themes. No other change is needed. If your new theme is named 'Editor', the folder should look like content/themes/Editor/...

vyronarediano · 2020-05-02T03:38:21Z

@vyronarediano You should copy the extracted contents inside contents/themes. No other change is needed. If your new theme is named 'Editor', the folder should look like content/themes/Editor/...

Alright, I see @aayushdutt. But by the way, when I did this, there were no changes to push in my git application.

Also, what would be the value of the theme in package.json (see screenshot above)?

Thanks

aayushdutt · 2020-05-02T03:40:28Z

As I said, no other change is needed. You don't need to change package.json at all. Just copy your theme and you are good to go.

vyronarediano · 2020-05-02T03:44:09Z

As I said, no other change is needed. You don't need to change package.json at all. Just copy your theme and you are good to go.

One last thing, what would be the value of the theme in package.json?

github:[username]/[name of the theme]?

aayushdutt · 2020-05-02T03:45:29Z

As I said, no other change is needed. You don't need to change package.json at all. Just copy your theme and you are good to go.

One last thing, what would be the value of the theme in package.json?

You don't need to change it. Just let it be what it is currently.
You will be able to see your new theme in the Ghost Admin panel

vyronarediano · 2020-05-02T03:46:49Z

As I said, no other change is needed. You don't need to change package.json at all. Just copy your theme and you are good to go.

One last thing, what would be the value of the theme in package.json?

You don't need to change it. Just let it be what it is currently.
You will be able to see your new theme in the Ghost Admin panel

Alright. Thank you so much for your help! Really appreciate it :)

vyronarediano · 2020-05-02T11:30:19Z

u should copy the extracted contents inside contents/themes. No other change is needed. If your new theme is named 'Editor', the folder should look like content/themes/Editor/...

Hello @aayushdutt, I just copied the theme and made the folder look like the one you said but there were no changes to commit and push.

jerinjacob1999 · 2020-05-02T11:34:03Z

@vyronarediano there will not be, becuase new folders, has to add manually, if you are using heroku free quota , I don't personally recommend this method,do thing as I told before check my website.
https://cybergenie.tech

aayushdutt · 2020-05-02T11:45:34Z

@vyronarediano
Oh, sorry my bad. I forgot to mention you need to remove content/themes/* from .gitignore.

ghost-on-heroku/.gitignore

Line 9 in 842970d

content/themes/*

aayushdutt · 2020-05-02T11:48:18Z

@vyronarediano there will not be, becuase new folders, has to add manually, if you are using heroku free quota , I don't personally recommend this method

@jerinjacob1999 could you please explain a bit more. I am sorry I couldn't get what you mean.

vyronarediano · 2020-05-02T13:27:54Z

@vyronarediano
Oh, sorry my bad. I forgot to mention you need to remove content/themes/* from .gitignore.

ghost-on-heroku/.gitignore

Line 9 in 842970d

content/themes/*

Thank you @aayushdutt! Now I'm worried about the Theme might get stolen because it is a public repo.

aayushdutt · 2020-05-02T13:33:14Z

@vyronarediano If you need to make your repo private, instead of forking this repository, do the following

Create a private repository
Clone this repository
Update remote URL: git remote set-url origin <remote-url>
Proceed as normal in the next steps

Now your changes will be pushed to your private repository.

vyronarediano · 2020-05-02T13:38:25Z

@vyronarediano If you need to make your repo private, instead of forking this repository, do the following

Create a private repository

Clone this repository

Update remote URL: git remote set-url origin <remote-url>

Proceed as normal in the next steps

Now your changes will be pushed to your private repository.

Awesome. Thank you @aayushdutt for being helpful!

noelldev · 2020-05-03T10:13:05Z

To use a new theme:

Fork this repository

Clone it and copy your theme in content/themes

Remove content/themes/* from .gitignore

Push the change

Deploy

In case you wish to update existing deployment, follow updating-source-code instead of step 4
I think this should work @vyronarediano

@aayushdutt, Thanks for sharing if I do this by just upgrading the version of my theme and redeploy how about my previous changes, will it be save or will go back to the bare state of site. Thanks!!!

aayushdutt · 2020-05-03T10:36:07Z

@kodrr All your data should be safe in the MySQL database. You don't need to worry about that.

noelldev · 2020-05-03T11:11:32Z

@kodrr All your data should be safe in the MySQL database. You don't need to worry about that.

@aayushdutt, Actually I just did a theme ver update by just editing package.json then pushing directly to heroku w/o cloning the theme itself to the content folder it seems this is more efficient for me. Thanks, Cheers!!!

aayushdutt · 2020-05-03T11:13:16Z

@kodrr yeah that is the best method for using and updating open source themes

kasindhu · 2020-05-08T20:58:30Z

Hello @aayushdutt,

What should be the value of my theme?

and as you said "Clone it and copy your theme in content/themes" - Is this in zip file format? or the extracted one? because upon uploading it in content/themes there were no changes to push.
Only when I edit the package.json and copytheme.sh.

Many thanks in advance.

Sorry this is my doing.That theme is not public. I have removed accordingly from fork. Please contact the author for theme.

kasindhu · 2020-05-08T21:00:03Z

Even after adding s3 storage backend, the only files uploaded are images. The theme is not uploaded to the S3 bucket.

rista404 · 2020-05-26T11:08:01Z

I managed to upload my theme with these steps:

heroku git:clone -a your-app
cd your-app
git remote add origin https://github.com/SNathJr/ghost-on-heroku
git pull origin master
# extract zip file of your theme inside `content/themes` dir
# remove content/themes from .gitignore
git commit -am "Add theme"
git push heroku master # deploys the theme

boxedpaul · 2020-06-25T12:55:26Z

Thanks for all your help. I have had problems with the themes before and these instructions helped. Now I need to add some redirects via redirects.json. I'm expecting I'll have the same problems.

Do you have any suggestions for how to fix this? Happy to open another issue if it's not similar enough.

hegioncom · 2020-10-09T17:42:17Z

I managed to upload my theme with these steps:

heroku git:clone -a your-app
cd your-app
git remote add origin https://github.com/SNathJr/ghost-on-heroku
git pull origin master
# extract zip file of your theme inside `content/themes` dir
# remove content/themes from .gitignore
git commit -am "Add theme"
git push heroku master # deploys the theme

Great summary. I do have a question though:

Question 1: I've followed your step, but the new theme is still not reflected when i return to my dashboard

Here's what I did:

cd <my-local-directory-folder>
heroku git:clone -a <my-heroku-app-name>
cd <my-heroku-app-name>
git remote add origin https://github.com/SNathJr/ghost-on-heroku
git pull origin master
# I've extracted zip file of my theme inside `content/themes` dir 
cat .gitignore
git rm -r --cached content/themes 
# I've performed the 2 steps above to remove content/themes from .gitignore
git commit -m 'Remove newly ignored directory "content/themes"'
git push origin master
git commit -am "Add <my-heroku-app-name> theme"
git push heroku master 
# tried to deploy the theme

But after checking my dashboard, my theme is still not appearing.

Anyone there to help? thanks!

aayushdutt changed the title ~~Add support for Theme Upload~~ Add support for Theme upload Jun 27, 2019

SNathJr added the enhancement New feature or request label Jun 30, 2019

JaneJeon mentioned this issue Aug 14, 2019

Themes keep getting deleted #13

Closed

ankittaneja mentioned this issue Oct 28, 2019

Internal Server Error on Image upload to S3 #22

Closed

JaneJeon mentioned this issue Jan 23, 2020

Can't update theme, changes to *.hbs files do not render consistently #44

Closed

stale bot added the wontfix This will not be worked on label Jan 30, 2020

SNathJr removed the wontfix This will not be worked on label Feb 1, 2020

stale bot added the wontfix This will not be worked on label Feb 16, 2020

stale bot closed this as completed Feb 19, 2020

aayushdutt mentioned this issue Feb 19, 2020

Add stale bot #45

Closed

JaneJeon removed the wontfix This will not be worked on label Feb 19, 2020

JaneJeon assigned SNathJr Feb 19, 2020

JaneJeon reopened this Feb 19, 2020

aayushdutt closed this as completed May 1, 2020

aayushdutt reopened this May 1, 2020

JaneJeon linked a pull request May 2, 2020 that will close this issue

Add instructions to add your own themes. #52

Closed

backspace mentioned this issue Aug 26, 2020

Update to use Ghost’s user-editable navigation winnipegpolicecauseharm/wpch-ghost-theme#7

Merged

ghost deleted a comment Jan 3, 2022

Add support for Theme upload #9

Add support for Theme upload #9

Comments

aayushdutt commented Jun 27, 2019

SNathJr commented Jun 28, 2019

aayushdutt commented Jun 28, 2019 • edited Loading

SNathJr commented Jun 30, 2019

aayushdutt commented Jul 13, 2019

SNathJr commented Aug 13, 2019

codechair commented Jan 22, 2020

SNathJr commented Jan 23, 2020

stale bot commented Jan 30, 2020

xjose97x commented Feb 3, 2020

SNathJr commented Feb 7, 2020 • edited Loading

BadBrahmin commented Feb 9, 2020

stale bot commented Feb 16, 2020

dwanderton commented Mar 26, 2020

jerinjacob1999 commented Apr 16, 2020 • edited Loading

stephenajulu commented Apr 28, 2020

vyronarediano commented May 1, 2020

jerinjacob1999 commented May 1, 2020

vyronarediano commented May 1, 2020 • edited Loading

aayushdutt commented May 1, 2020 • edited Loading

vyronarediano commented May 2, 2020 • edited Loading

aayushdutt commented May 2, 2020 • edited Loading

vyronarediano commented May 2, 2020 • edited Loading

aayushdutt commented May 2, 2020

vyronarediano commented May 2, 2020

vyronarediano commented May 2, 2020 • edited Loading

jerinjacob1999 commented May 2, 2020 • edited Loading

aayushdutt commented May 2, 2020 • edited Loading

aayushdutt commented May 2, 2020

vyronarediano commented May 2, 2020

aayushdutt commented May 2, 2020

vyronarediano commented May 2, 2020

noelldev commented May 3, 2020

aayushdutt commented May 3, 2020

noelldev commented May 3, 2020 • edited Loading

aayushdutt commented May 3, 2020

kasindhu commented May 8, 2020 • edited Loading

kasindhu commented May 8, 2020

rista404 commented May 26, 2020

boxedpaul commented Jun 25, 2020

hegioncom commented Oct 9, 2020 • edited Loading

Great summary. I do have a question though:

aayushdutt commented Jun 28, 2019 •

edited

Loading

SNathJr commented Feb 7, 2020 •

edited

Loading

jerinjacob1999 commented Apr 16, 2020 •

edited

Loading

vyronarediano commented May 1, 2020 •

edited

Loading

aayushdutt commented May 1, 2020 •

edited

Loading

vyronarediano commented May 2, 2020 •

edited

Loading

aayushdutt commented May 2, 2020 •

edited

Loading

vyronarediano commented May 2, 2020 •

edited

Loading

vyronarediano commented May 2, 2020 •

edited

Loading

jerinjacob1999 commented May 2, 2020 •

edited

Loading

aayushdutt commented May 2, 2020 •

edited

Loading

noelldev commented May 3, 2020 •

edited

Loading

kasindhu commented May 8, 2020 •

edited

Loading

hegioncom commented Oct 9, 2020 •

edited

Loading