Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hide controls when animating in and out of PiP #626

Closed
4 tasks done
defagos opened this issue Nov 5, 2023 · 1 comment
Closed
4 tasks done

Hide controls when animating in and out of PiP #626

defagos opened this issue Nov 5, 2023 · 1 comment
Labels
enhancement New feature or request
Milestone

Comments

@defagos
Copy link
Member

defagos commented Nov 5, 2023

As a user I want a nice experience when animating in and out of PiP.

Acceptance criteria

  • Controls are hidden when transitioning from / to PiP.

Tasks

  • Publish state from PictureInPicture.
  • Hide UI in demos implementing PiP when transitioning.
  • Avoid showing controls when returning from PiP.
  • Return isPossible as false when transitioning out of PiP? (would avoid button flickering)
@defagos defagos added this to Pillarbox Nov 5, 2023
@defagos defagos converted this from a draft issue Nov 5, 2023
@defagos defagos added this to the PiP milestone Nov 5, 2023
@defagos defagos added the enhancement New feature or request label Nov 5, 2023
@defagos
Copy link
Member Author

defagos commented Nov 20, 2023

Not really relevant anymore. Apps can use our PictureInPictureButton which uses these states internally. No need to hide controls during animation as well since we could implement very fast transitions in and out of PiP.

@defagos defagos closed this as completed Nov 20, 2023
@github-project-automation github-project-automation bot moved this from 📋 Backlog to ✅ Done in Pillarbox Nov 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: ✅ Done
Development

No branches or pull requests

1 participant