Cast timeout to integer. #184
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
smarlowucf
commented
Mar 18, 2019
smarlowucf
commented
- Timeout will always have a default so no issue with casting None.
- Print instance id as soon as possible in case of error.
Print instance id as soon as possible in case of error.
bear454
reviewed
Mar 18, 2019
| @@ -140,7 +140,7 @@ def __init__( | |||
| self.inject = self.ipa_config['inject'] | |||
| self.instance_type = self.ipa_config['instance_type'] | |||
| self.test_files = list(self.ipa_config['test_files']) | |||
| self.timeout = self.ipa_config['timeout'] | |||
| self.timeout = int(self.ipa_config['timeout']) | |||
There was a problem hiding this comment.
Is it possible for self.ipa_config['timeout'] to be None ?
There was a problem hiding this comment.
No there is a default value. https://github.com/SUSE-Enceladus/ipa/blob/master/ipa/ipa_cloud.py#L51
bear454
approved these changes
Mar 18, 2019
rjschwei
approved these changes
Mar 19, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.