- Use the "baseproduct" link as indicator of the product, SLES vs. SL… #208
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ES4SAP
+ If the baseproduct link is not correct then registration would also not
be correct. Thus the link is a more reliable indicator as compared to the
information in os-release
smarlowucf
requested changes
Jun 26, 2019
- Check baseproduct link in is_sles_sap fixture. - Inject is_sles_sap fixture into get_smt_servers fixture.
|
@rjschwei Updated per comments. |
+ When we get the base product information it is unknown if it is "sles"
or some other baseproduct. Therefore the function name should not include
a specific product name. This would imply the the function makes a
judgement whether or not the baseproduct matches the product in the name.
|
@smarlowucf thanks for the help, just made a name change from "get_sles_baseproduct" to "get_baseproduct" having "sles" in the name would imply we are looking for SLES, but the implementation doesn't care it will return whatever "baseproduct" links to, which is what we want. |
smarlowucf
approved these changes
Jul 2, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ES4SAP
be correct. Thus the link is a more reliable indicator as compared to the
information in os-release