Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make tox env work with python3.7 #209

Merged
merged 1 commit into from
Jul 1, 2019
Merged

Make tox env work with python3.7 #209

merged 1 commit into from
Jul 1, 2019

Conversation

jgleissner
Copy link
Contributor

Added py37 to tox.ini to make tox environment work on Tumbleweed.
Also fixed a typo that broke testing.

@rjschwei rjschwei requested a review from smarlowucf July 1, 2019 13:43
@rjschwei
Copy link
Collaborator

rjschwei commented Jul 1, 2019

@jgleissner

LGTM,

Added @smarlowucf as reviewer, please re-push the commit signed

@jgleissner
Copy link
Contributor Author

Sorry, my GPG key was expired. Refreshed.

smarlowucf
smarlowucf approved these changes Jul 1, 2019
View reviewed changes
Copy link
Collaborator

@smarlowucf smarlowucf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@smarlowucf smarlowucf merged commit 1436858 into master Jul 1, 2019
@smarlowucf smarlowucf deleted the py37 branch July 1, 2019 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@smarlowucf smarlowucf smarlowucf approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jgleissner @rjschwei @smarlowucf