Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Indicate retryable error (GCE only) #211

Merged
merged 3 commits into from
Jul 16, 2019
Merged

Indicate retryable error (GCE only) #211

merged 3 commits into from
Jul 16, 2019

Conversation

jgleissner
Copy link
Contributor

If instance cannot be launched in GCE due to quota restriction, throw IpaRetryableError exception.

@jgleissner
Indicate retryable error (GCE only)
1cdc304 
If instance cannot be launched in GCE due to quota restricition, throw
IpaRetryableError exception.
@smarlowucf
Copy link
Collaborator

smarlowucf commented Jul 16, 2019 •
edited
Loading

Looks good but there are some format errors:

$ flake8 img_proof
img_proof/ipa_gce.py:236:9: F841 local variable 'error' is assigned to but never used
img_proof/ipa_exceptions.py:43:1: E302 expected 2 blank lines, found 1
img_proof/ipa_exceptions.py:46:1: E302 expected 2 blank lines, found 1
img_proof/ipa_exceptions.py:81:1: E302 expected 2 blank lines, found 1
img_proof/ipa_exceptions.py:84:1: E302 expected 2 blank lines, found 1

@smarlowucf smarlowucf mentioned this pull request Jul 16, 2019
Merged
smarlowucf
smarlowucf requested changes Jul 16, 2019
View reviewed changes
img_proof/ipa_gce.py Outdated
except QuotaExceededError as error:
raise GCECloudRetryableError(
'An error occurred launching instance: {message}.'.format(
message=message
Copy link
Collaborator

@smarlowucf smarlowucf Jul 16, 2019 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

message is not in scope. Should be error or error.value['message']?

@smarlowucf smarlowucf merged commit fb950d1 into master Jul 16, 2019
@smarlowucf smarlowucf deleted the gce-retryable-error branch July 16, 2019 16:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@smarlowucf smarlowucf smarlowucf requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jgleissner @smarlowucf