Migrate GCE to Google API. #242
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I will follow up with a PR to integrate the boot firmware and secure boot options. Also, I dropped the GCERetryableError as it seemed unnecessary because it was caught internally and re-raised as the IPARetryableError. Simplifies the code to just raise the base IPA error directly. |
Google API supports guest os features which is required to test UEFI firmware and secure boot functionality in instances.
Error content when running in python3.5 is bytes not string.
|
Added image_project option to allow testing images not in service_account project. And appended a commit to add enable secure boot and enable UEFI options. If secure boot is enabled UEFI will be enabled by default. |
jgleissner
approved these changes
Apr 17, 2020
This is not available when using google-auth and causes a failed code path. Explicitly disabling prevents cruft in log files.
|
I pushed another quick fix to disable cache_discovery as it's not available anyway when using google-auth. |
rjschwei
approved these changes
Apr 21, 2020
TERMINATED state for a stopped instance can be confusing. Fix malformed docstring in get_message_from_http_error method.
|
Fixed the comments and added a link to the GCE instance lifecycle docs. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Google API supports guest os features which is required to test UEFI firmware and secure boot functionality in instances.