Catch unhandled exceptions from pytest. #266
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- And retry the given test. - Also, disable all pytest stdout capturing with -s option. This seems to clash with img-proof which already redirects stdout to a log file. https://docs.pytest.org/en/stable/capture.html
rjschwei
approved these changes
Sep 25, 2020
bear454
approved these changes
Sep 25, 2020
img_proof/ipa_cloud.py
Outdated
| try: | ||
| result = pytest.main(cmds, plugins=[plugin]) | ||
| except Exception: | ||
| result = 2 |
There was a problem hiding this comment.
Pytest returns 1 if tests fail, 0 if sucess and any of 2, 3, 4 if there's some sort of handled exception. So 2 is arbitrary, it could be 2, 3 or 4. Below this section where the results are handled if the result is in (2, 3, 4) img-proof only adds a generic error instead of trying to parse the plugin report which won't exist in exception cases.
There was a problem hiding this comment.
Consider adding that to the README and/or documentation.
There was a problem hiding this comment.
Will add comments before merge.
|
Add a comment to point to pytest error code link and use error code 3 which match exception cases. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
seems to clash with img-proof which already redirects stdout to a
log file. https://docs.pytest.org/en/stable/capture.html