Fix SEV CAPABLE function #273
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The config is not set in all images yet.
There are multiples flags that need to be set to enable the feature in an instance.
Checks dmesg output to confirm confidential compute is active in an instance.
rjschwei
reviewed
Oct 20, 2020
| @@ -0,0 +1,4 @@ | |||
| def test_sles_gce_sev(host): | |||
| expected = 'AMD Secure Encrypted Virtualization (SEV) active' | |||
There was a problem hiding this comment.
Let's see how long this let's, maybe we get lucky and the message will stick. If not we can simplify and look for "SEV" and "active" rather than matching the hole string.
There was a problem hiding this comment.
Right, if we want to make it simpler now that seems good but it's nice to be as expressive as possible without causing us any false negatives. Since the command is already grepping on SEV we really only need to expect active to be in the output.
rjschwei
approved these changes
Oct 20, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I went with the full string match for SEV test. If it turns out to be troublesome we can make it less explicit.