- Add test to ensure we have a dracut configuration that contains all…

[rjschwei]

… the

drivers necessary to support instance type switching between nitro and
xen based instances

[smarlowucf]

This would be better as a paramterized test. That way each driver is tested individually and it makes failure explicit. E.g. a paramterized test would look like test_sles_dracut_conf[ena]. See https://github.com/SUSE-Enceladus/img-proof/blob/master/usr/share/lib/img_proof/tests/SLES/EC2/test_sles_ec2_services.py.

[rjschwei]

This would be better as a paramterized test. That way each driver is tested individually and it makes failure explicit. E.g. a paramterized test would look like test_sles_dracut_conf[ena]. See https://github.com/SUSE-Enceladus/img-proof/blob/master/usr/share/lib/img_proof/tests/SLES/EC2/test_sles_ec2_services.py.

But that also implies we are making 7 connections to the host to read the same file 7 times unless we create a global cache of the content. Not sure the global cache is an elegant solution. But reading the same file from the host multiple times is not a good idea.

[smarlowucf]

Given pytest parses the test at once I believe it's only one connection. I don't really see the concern about opening a file seven times. To me avoiding that without seeing a noticeable performance issue would be premature optimization.

It will also become a big headache if the test fails and is not parameterized because even with the API right now you only see test pass/fail. Which means you'd have no idea which driver is missing.

[rjschwei]

Well it would not pre-mature optimization if in fact a network connection is established to read the same file 7 times over. Anyway, I do not have the spare time to dig into what pytest actually does, I don't like the idea of a global cache and do not like the loop. SO I guess we'lll just not test for this. We'd have to establish what pytest actually does in order to move forward.

[smarlowucf]

Re-opened, I don't see the point of ignoring the test.

[smarlowucf]

/s/drivers/driver

[rjschwei]

Typo fixed. But again I am happy to pull this if you think the loop is not OK, the close was just intended to not leave this dangling for investigation into pytest behavior with respect to network connection opening. Alternative to parameterize and avoid the investigation into pytest

dracut_conf = ''

@pytest....
def test_sles_dracut_conf(host,driver):
    global dracut_conf
    if not dracut_conf:
         dracut_conf = host.file('/etc/dracut.conf.d/07-aws-type-switch.conf')
    assert dracut_conf.contains(driver)

should work, but that has the global which is not particularly pretty either