Add inject option for ipa testing. #78
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Provides the following options for injection:
:inject_packages: an rpm path or list of rpm paths which will be
copied and installed on instance.
:inject_archives: an archive or list of archives which will
be copied and extracted on instance.
:inject_files: a file path or list of file paths which
will be copied to instance.
:execute: a command or list of commands to run.
:install: a package name or list of package names to
install from an existing repo.
The injection happens in that order.
smarlowucf
force-pushed
the
inject-requirements
branch
from
6628740
to
b6155f4
Compare
rjschwei
requested changes
May 14, 2018
ipa/ipa_provider.py
Outdated
| There are 5 injection options: | ||
|
|
||
| :inject_packages: an rpm path or list of rpm paths which will be | ||
| copied and installed on instance. |
There was a problem hiding this comment.
... installed on the test instance.
ipa/ipa_provider.py
Outdated
| :inject_packages: an rpm path or list of rpm paths which will be | ||
| copied and installed on instance. | ||
| :inject_archives: an archive or list of archives which will | ||
| be copied and extracted on instance. |
ipa/ipa_provider.py
Outdated
| :inject_archives: an archive or list of archives which will | ||
| be copied and extracted on instance. | ||
| :inject_files: a file path or list of file paths which | ||
| will be copied to instance. |
ipa/ipa_provider.py
Outdated
| will be copied to instance. | ||
| :execute: a command or list of commands to run. | ||
| :install: a package name or list of package names to | ||
| install from an existing repo. |
There was a problem hiding this comment.
Please add the order of processing to the doc string
| inject_files = [inject_files] | ||
|
|
||
| for file_path in inject_files: | ||
| self.put_file(client, file_path) |
There was a problem hiding this comment.
One could, and some people will argue that packages and tar archives are files as well. I am OK leaving this option as if one want to inject a config file that effects a package forcing them to create an archive is silly and it saves us the logic of having to determine file types for certain operation.
There was a problem hiding this comment.
Yeah "put" is the first step to injecting a package and an archive. So exposing it independently I think is nice. I.e. like your example to copy a single file.
rjschwei
approved these changes
May 15, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Provides the following options for injection:
:inject_packages: an rpm path or list of rpm paths which will be copied and installed on instance.
:inject_archives: an archive or list of archives which will be copied and extracted on instance.
:inject_files: a file path or list of file paths which will be copied to instance.
:execute: a command or list of commands to run.
:install: a package name or list of package names to install from an existing repo.
The injection happens in that order.