Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Iterate SWIFTGalaxy's efficiently #13

Closed
kyleaoman opened this issue Sep 12, 2024 · 0 comments · Fixed by #14
Closed

Iterate SWIFTGalaxy's efficiently #13

kyleaoman opened this issue Sep 12, 2024 · 0 comments · Fixed by #14
Assignees
Labels
enhancement New feature or request

Comments

@kyleaoman
Copy link
Member

kyleaoman commented Sep 12, 2024

If we want to iterate over many galaxies that lie in the same top-level cell(s) in the snapshot then creating separate SWIFTGalaxy objects will be inefficient because each time a SWIFTGalaxy is created the same particles will be read from disk, and then all but those corresponding to the halo of interest will be discarded. Instead we would like to do the expensive disk i/o once and then temporarily mask out particles that don't belong to the current galaxy of interest while iterating over galaxies.

@kyleaoman kyleaoman added the enhancement New feature or request label Sep 12, 2024
@kyleaoman kyleaoman self-assigned this Sep 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant