Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: added MNIST, Fashion-MNIST and KMNIST datasets #164

Merged
merged 18 commits into from
Jul 12, 2024
Merged

feat: added MNIST, Fashion-MNIST and KMNIST datasets #164

merged 18 commits into from
Jul 12, 2024

Conversation

Marsmaennchen221
Copy link
Contributor

@Marsmaennchen221 Marsmaennchen221 commented May 8, 2024 •
edited
Loading

Closes #161
Closes #162
Closes #163

Summary of Changes

feat: added MNIST, Fashion-MNIST and KMNIST datasets
build: bump safe-ds to ^0.24.0

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented May 8, 2024 •
edited
Loading

🦙 MegaLinter status: ✅ SUCCESS

Descriptor Linter Files Fixed Errors Elapsed time
✅ PYTHON black 6 0 0 0.62s
✅ PYTHON mypy 6 0 1.76s
✅ PYTHON ruff 6 0 0 0.04s
✅ REPOSITORY git_diff yes no 0.03s

See detailed report in MegaLinter reports
Set VALIDATE_ALL_CODEBASE: true in mega-linter.yml to validate all sources, not only the diff

MegaLinter is graciously provided by OX Security

@codecov Codecov
Copy link

codecov bot commented May 8, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (90de957) to head (d410992).

Additional details and impacted files 
@@            Coverage Diff             @@
##              main      #164    +/-   ##
==========================================
  Coverage   100.00%   100.00%            
==========================================
  Files            7        10     +3     
  Lines           37       151   +114     
==========================================
+ Hits            37       151   +114

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Marsmaennchen221
Copy link
Contributor Author

@lars-reimann Currently, the tests download each dataset once. Therefore, the tests take a while. Do you have an idea what we could do about that?

@Marsmaennchen221
Copy link
Contributor Author

@lars-reimann as soon as the next release of the Library is published, we can merge this pr

@lars-reimann
Copy link
Member

lars-reimann commented May 9, 2024 •
edited
Loading

@lars-reimann Currently, the tests download each dataset once. Therefore, the tests take a while. Do you have an idea what we could do about that?

https://github.com/actions/cache could help here, if the data is not too large. We have 10 GB for caches in total.

@Marsmaennchen221
Copy link
Contributor Author

@lars-reimann Currently, the tests download each dataset once. Therefore, the tests take a while. Do you have an idea what we could do about that?

https://github.com/actions/cache could help here, if the data is not too large. We have 10 GB for caches in total.

Ok I will look at this at a later time. For now, this pr is ready.

@Marsmaennchen221 Marsmaennchen221 marked this pull request as ready for review May 9, 2024 16:08
@Marsmaennchen221 Marsmaennchen221 requested a review from a team as a code owner May 9, 2024 16:08
@Marsmaennchen221 Marsmaennchen221 mentioned this pull request May 9, 2024
Open
@lars-reimann
Copy link
Member

OK, thanks. Review will take a while. I have other priorities right now.

@Marsmaennchen221 Marsmaennchen221 mentioned this pull request May 19, 2024
Merged
@lars-reimann lars-reimann merged commit 97ae47a into main Jul 12, 2024
7 checks passed
@lars-reimann lars-reimann deleted the add-mnist-datasets branch July 12, 2024 07:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lars-reimann lars-reimann lars-reimann approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add the KMNIST Dataset Add the Fashion-MNIST Dataset Add the MNIST Dataset
3 participants
@Marsmaennchen221 @lars-reimann @megalinter-bot