Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Certain pattern will create an @enum annotation, even though it should be a UnionType #42

Open
Masara opened this issue Jun 24, 2022 · 0 comments
Open

Certain pattern will create an @enum annotation, even though it should be a UnionType #42

Masara opened this issue Jun 24, 2022 · 0 comments
Labels
bug 🪲 Something isn't working @enum Related to the @enum annotation wrong annotation An annotation was generated automatically but is incorrect

Comments

@Masara
Copy link
Contributor

Masara commented Jun 24, 2022 •
edited by lars-reimann
Loading

Is your feature request related to a problem?

Currently, the pattern

    stop_words : {'english'}, list, default=None

will result in an @enum annotation.

Desired solution

It should be a UnionType (with, in this case, Enum, List and None types).

Possible alternatives (optional)

No response

Screenshots (optional)

Screenshots of the current state:
image
image
image

Additional Context (optional)

Examples:

  • #/sklearn/sklearn.metrics._classification/f1_score/average
@Masara Masara added the enhancement 💡 New feature or request label Jun 24, 2022
@lars-reimann lars-reimann mentioned this issue Jun 24, 2022
Closed
@lars-reimann lars-reimann changed the title Certain pattern will create an @enum annotiation, even tho it should be an UnionType Certain pattern will create an @enum annotiation, even though it should be an UnionType Jun 24, 2022
@lars-reimann lars-reimann changed the title Certain pattern will create an @enum annotiation, even though it should be an UnionType Certain pattern will create an @enum annotiation, even though it should be a UnionType Jun 24, 2022
@lars-reimann lars-reimann changed the title Certain pattern will create an @enum annotiation, even though it should be a UnionType Certain pattern will create an @enum annotation, even though it should be a UnionType Jun 24, 2022
@lars-reimann lars-reimann added @enum Related to the @enum annotation bug 🪲 Something isn't working wrong annotation An annotation was generated automatically but is incorrect and removed enhancement 💡 New feature or request labels Jun 25, 2022
@lukarade lukarade mentioned this issue Jul 1, 2022
Open
@lars-reimann lars-reimann mentioned this issue Mar 19, 2023
Open
7 tasks
@lars-reimann lars-reimann transferred this issue from Safe-DS/API-Editor Mar 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug 🪲 Something isn't working @enum Related to the @enum annotation wrong annotation An annotation was generated automatically but is incorrect
Projects
Library Analysis
Status: Backlog
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Masara @lars-reimann