Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test_discretizer.py raises warnings #434

Open
zzril opened this issue Jul 7, 2023 · 0 comments
Open

test_discretizer.py raises warnings #434

zzril opened this issue Jul 7, 2023 · 0 comments
Assignees
Labels
cleanup 🧹 Refactorings and other tasks that improve the code testing 🧪 Additional automated tests

Comments

@zzril
Copy link
Contributor

zzril commented Jul 7, 2023

Describe the bug

test_discretizer.py produces 6 warnings that are currently not catched by the tests.

To Reproduce

Checkout main.
(For reference: I observed the behaviour on commit 5e3da8d.)

Run pytest from the console. (Or poetry run pytest.)

9 warnings will be shown.
(Note that the first 3 are already addressed by current PR #425.)

Expected behavior

Test should not raise warnings.

If the warnings are supposed to be raised, catch them in the tests.
If they are not raised by us, understand why they happen and change the library code in a way that does not generate warnings. (If nothing else works, silence them in our library code.)

@zzril zzril added testing 🧪 Additional automated tests cleanup 🧹 Refactorings and other tasks that improve the code labels Jul 7, 2023
@lars-reimann lars-reimann self-assigned this May 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cleanup 🧹 Refactorings and other tasks that improve the code testing 🧪 Additional automated tests
Projects
Status: Backlog
Development

No branches or pull requests

2 participants