Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add to tagged_table/for neural network #618

Closed
Gerhardsa0 opened this issue Apr 10, 2024 · 2 comments · Fixed by #615
Closed

feat: add to tagged_table/for neural network #618

Gerhardsa0 opened this issue Apr 10, 2024 · 2 comments · Fixed by #615
Labels
enhancement 💡 New feature or request wontfix This will not be worked on

Comments

@Gerhardsa0
Copy link
Contributor

Gerhardsa0 commented Apr 10, 2024

Is your feature request related to a problem?

Right now, the nn interface only allows TaggedTable as an input.

For TimeSeries I will add a temporary solution, with to_tagged_table, which converts the TimeSeries into a tagged table. This can also be useful for the future implementation of the InputLayer of the nn Interface.

Desired solution

Right now just a temporary solution and the Integration into the InputLayer Interface.

The lag parameter could also take place here

@Gerhardsa0 Gerhardsa0 added the enhancement 💡 New feature or request label Apr 10, 2024
@github-project-automation github-project-automation bot moved this to Backlog in Library Apr 10, 2024
@Gerhardsa0 Gerhardsa0 self-assigned this Apr 10, 2024
@Gerhardsa0 Gerhardsa0 linked a pull request Apr 10, 2024 that will close this issue
@Gerhardsa0
Copy link
Contributor Author

This is not a good way to solve the problem, as the windows are not held as data internally and are more used a schema for the data to load into the tensors.

So some deeper changes will be made.

@Gerhardsa0 Gerhardsa0 added the invalid This doesn't seem right label Apr 10, 2024
@Gerhardsa0 Gerhardsa0 closed this as not planned Won't fix, can't repro, duplicate, stale Apr 10, 2024
@github-project-automation github-project-automation bot moved this from Backlog to ✔️ Done in Library Apr 10, 2024
@Gerhardsa0 Gerhardsa0 removed the invalid This doesn't seem right label Apr 10, 2024
@lars-reimann
Copy link
Member

lars-reimann commented Apr 10, 2024

Seems related to our discussion about input/output layers that handle the conversion from/to tensors. Also seems related to @Marsmaennchen221's work on a DataSet class for images.

@lars-reimann lars-reimann added the wontfix This will not be worked on label Apr 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement 💡 New feature or request wontfix This will not be worked on
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants