feat: remove output conversions #792
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦙 MegaLinter status: ✅ SUCCESS
See detailed report in MegaLinter reports MegaLinter is graciously provided by |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #792 +/- ##
==========================================
- Coverage 97.76% 97.73% -0.04%
==========================================
Files 111 110 -1
Lines 5691 5659 -32
==========================================
- Hits 5564 5531 -33
- Misses 127 128 +1 ☔ View full report in Codecov by Sentry. |
lars-reimann
requested review from
Gerhardsa0,
Marsmaennchen221 and
sibre28
as code owners
lars-reimann
pushed a commit
that referenced
this pull request
May 29, 2024
## [0.26.0](v0.25.0...v0.26.0) (2024-05-29) ### Features * `Table.count_row_if` ([#788](#788)) ([4137131](4137131)), closes [#786](#786) * added method to load pretrained models from huggingface ([#790](#790)) ([dd8394b](dd8394b)) * infer input size of forward and LSTM layers ([#808](#808)) ([098a07f](098a07f)) * outline around dots of scatterplot ([#785](#785)) ([ee8acf7](ee8acf7)) * remove output conversions ([#792](#792)) ([46f2f5d](46f2f5d)), closes [#732](#732) * shorten some excessively long names ([#787](#787)) ([1c3ea59](1c3ea59)), closes [#772](#772) * specify column names in constructor of table transformers ([#795](#795)) ([69a780c](69a780c)) * store window size and forecast horizon in dataset ([#794](#794)) ([f07bc5a](f07bc5a)) * string operations on cells ([#791](#791)) ([4a17f76](4a17f76)) ### Bug Fixes * handling of boolean columns in column statistics ([#778](#778)) ([f61cceb](f61cceb)) * sort x values of line plot ([#782](#782)) ([74d8649](74d8649))
|
🎉 This PR is included in version 0.26.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes partially #732
Summary of Changes
Output conversions are the exact inversion of the input conversion, so there is no need to specify them again. Now, a neural network only takes an input conversion and a list of layers. This also gets rid of several errors that could occur if input and output conversions did not fit together.
In a later PR, the input conversion will also be removed, since they mirror datasets.