Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: catch possible pickling errors #118

Merged
merged 5 commits into from
May 29, 2024
Merged

fix: catch possible pickling errors #118

merged 5 commits into from
May 29, 2024

Conversation

lars-reimann
Copy link
Member

@lars-reimann lars-reimann commented May 29, 2024

Summary of Changes

Catch pickling errors in two other locations where they might occur.

Copy link

github-actions bot commented May 29, 2024

🦙 MegaLinter status: ✅ SUCCESS

Descriptor Linter Files Fixed Errors Elapsed time
✅ PYTHON black 12 0 0 1.01s
✅ PYTHON mypy 12 0 2.74s
✅ PYTHON ruff 12 0 0 0.03s
✅ REPOSITORY git_diff yes no 0.02s

See detailed report in MegaLinter reports
Set VALIDATE_ALL_CODEBASE: true in mega-linter.yml to validate all sources, not only the diff

MegaLinter is graciously provided by OX Security

Copy link

codecov bot commented May 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (27cc616) to head (2702c5b).
Report is 23 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #118   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           15        15           
  Lines          787       792    +5     
=========================================
+ Hits           787       792    +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lars-reimann lars-reimann marked this pull request as ready for review May 29, 2024 11:11
@lars-reimann lars-reimann requested a review from a team as a code owner May 29, 2024 11:11
@lars-reimann lars-reimann merged commit 6333b64 into main May 29, 2024
12 checks passed
@lars-reimann lars-reimann deleted the fix-pickle-errors branch May 29, 2024 11:11
lars-reimann pushed a commit that referenced this pull request May 29, 2024
## [0.17.0](v0.16.0...v0.17.0) (2024-05-29)

### Features

* require `safe-ds` version 0.26.0  ([#119](#119)) ([1360d9a](1360d9a))

### Bug Fixes

* catch possible pickling errors ([#118](#118)) ([6333b64](6333b64))
@lars-reimann
Copy link
Member Author

🎉 This PR is included in version 0.17.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@lars-reimann lars-reimann added the released Included in a release label May 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
released Included in a release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants