Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: runner startup crash #15

Merged
merged 12 commits into from
Nov 30, 2023
Merged

fix: runner startup crash #15

merged 12 commits into from
Nov 30, 2023

Conversation

WinPlay02
Copy link
Contributor

@WinPlay02 WinPlay02 commented Nov 30, 2023 •
edited by lars-reimann
Loading

Summary of Changes

  • fixes a crash on startup as the multiprocessing manager causes a new process to spawn during the bootstrap phase
  • this error only occurred during execution of the main.py with a new interpreter

@WinPlay02 WinPlay02 requested a review from a team as a code owner November 30, 2023 14:33
@codecov Codecov
Copy link

codecov bot commented Nov 30, 2023 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (035f64c) 100.00% compared to head (cd184da) 100.00%.

Additional details and impacted files 
@@            Coverage Diff            @@
##              main       #15   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            6         6           
  Lines          317       327   +10     
=========================================
+ Hits           317       327   +10

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 30, 2023 •
edited
Loading

🦙 MegaLinter status: ✅ SUCCESS

Descriptor Linter Files Fixed Errors Elapsed time
✅ PYTHON black 2 0 0 0.48s
✅ PYTHON mypy 2 0 1.56s
✅ PYTHON ruff 2 0 0 0.02s
✅ REPOSITORY git_diff yes no 0.01s

See detailed report in MegaLinter reports
Set VALIDATE_ALL_CODEBASE: true in mega-linter.yml to validate all sources, not only the diff

MegaLinter is graciously provided by OX Security

lars-reimann
lars-reimann requested changes Nov 30, 2023
View reviewed changes
src/safeds_runner/server/main.py Outdated Show resolved Hide resolved
tests/safeds_runner/server/test_websocket_mock.py Outdated Show resolved Hide resolved
lars-reimann
lars-reimann approved these changes Nov 30, 2023
View reviewed changes
Copy link
Member

@lars-reimann lars-reimann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thanks for the fast fix.

@lars-reimann lars-reimann merged commit 01df889 into main Nov 30, 2023
9 checks passed
@lars-reimann lars-reimann deleted the python-server-startup branch November 30, 2023 20:36
lars-reimann pushed a commit that referenced this pull request Nov 30, 2023
@semantic-release-bot
chore(release): 0.2.1 [skip ci]
7120cb5 
## [0.2.1](v0.2.0...v0.2.1) (2023-11-30)

### Bug Fixes

* add missing launch script ([#16](#16)) ([1564add](1564add))
* runner startup crash ([#15](#15)) ([01df889](01df889))
@lars-reimann
Copy link
Member

🎉 This PR is included in version 0.2.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@lars-reimann lars-reimann added the released Included in a release label Nov 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lars-reimann lars-reimann lars-reimann approved these changes

Assignees
No one assigned
Labels
released Included in a release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@WinPlay02 @lars-reimann @megalinter-bot