-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: support relative paths #83
Conversation
🦙 MegaLinter status: ✅ SUCCESS
See detailed report in MegaLinter reports |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #83 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 11 11
Lines 522 530 +8
=========================================
+ Hits 522 530 +8 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The code is fine, just one conceptual question: How does this work with memoization?
Changing the cwd
could lead to the same (relative) path resolving to different files.
As the timestamp is used to verify the valid re-usage of a file, this would probably not break correctness (and should be reasonably efficient, since the "older" files are not evicted from the cache (yet)), but it might cause confusion.
Could |
That should work, although reusing cached values between calls containing an absolute path and calls containing a relative path will not work. |
Another idea would be changing the code generator to create
instead of
|
The information about the parameters is available in the stubs via impurity information, so it could easily be added. |
I'll do that after lunch. |
🎉 This PR is included in version 0.10.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
### Summary of Changes Use the runner functionality added in Safe-DS/Runner#83 to support relative paths in pipeline files.
Closes #76
Summary of Changes
The
cwd
of the worker process can now be set via the newdata.cwd
item of theprogram
message.