Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create Donate (amount) Card and connect to GG Direct Donation #31

Open
5 tasks done
lauramorinigo opened this issue Oct 23, 2020 · 7 comments · Fixed by #43
Open
5 tasks done

Create Donate (amount) Card and connect to GG Direct Donation #31

lauramorinigo opened this issue Oct 23, 2020 · 7 comments · Fixed by #43
Assignees
Labels
enhancement New feature or request

Comments

@lauramorinigo
Copy link
Collaborator

lauramorinigo commented Oct 23, 2020

Provide the ability to the user to donate a certain x amount using the Donate Card under the donations tab:

  • Add Direct Donation Endpoint
  • Add Donate X card
  • Add Donate Endpoint
  • Add payment modal
  • Add Stripe integration
    Screenshot_20201023-164142_Samsung Global Goals
@lolaodelola
Copy link
Collaborator

Branch: https://github.com/SamsungInternet/globalgoals/tree/feature_donations

Blocked:

  • direct donation endpoint in test app is returning invalid JSON
  • Unable to call loadDirectDonation from card component, i.e. can't pass function to cActions

@lauramorinigo
Copy link
Collaborator Author

Current research about how to implement donations/payment method, things to solve:

  1. How to implement GDPR if data is collected, see options to not collect any data or rely on the native app
  2. How to use Stripe (include outside the US)
  3. Implementation of Web Payment API
  4. How to add Samsung Pay Web

@lolaodelola
Copy link
Collaborator

Stripe client side integration w/ WebPaymentsAPI:

client_side_stripe

@lauramorinigo
Copy link
Collaborator Author

lauramorinigo commented Nov 6, 2020

The donation by earnings workflow will be solved in a separate issue, check #40

Direct Donation with Stripe:

The web workflow is a little bit different than the native one, the web component shows directly the cards available without the option to choose between for example SPay and Gpay.
Chrome
On desktop, it doesn't retrieve the cards already connected with Gpay, on mobile yes.
Samsung Internet
The web component doesn't appear if there are no cards connected to the browser.

To Do

  • Research Samsung Pay Web Integration

@lauramorinigo
Copy link
Collaborator Author

We were able to integrate Stripe to donate but it's not working with Samsung Internet, it seems like it's not recognizing the Stripe payment method (the same thing was happening with Firefox Mobile).
After chatting with Stripe Support they told us that the browser is not supported but we had a case test example from other team members a few years ago. Looking for alternatives and feedback in order to make this feature available for SI.
A new issue was created to follow up this #44

@lauramorinigo
Copy link
Collaborator Author

If the user doesn't have any card attached show a message telling that it should attach a card to the browser.
@lolaodelola

@lauramorinigo lauramorinigo reopened this Dec 17, 2020
@lolaodelola
Copy link
Collaborator

@lauramorinigo that's done & pushed up now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants