ESLint: Add Node plugin with recommended preset for /build folder (De…

…vExpress#12994)

* ESLint: Add node plugin with recommended preset

* ESLint: Disable "node/no-unpublished-require" rule

* ESLint: Specify Node version for "no-unsupported-features/node-builtins" rule

* ESLint: Configure "shebang" rule

* Use strict

* new Buffer(string) -> Buffer.from(string)

* Ignore remaining lines

* Disable doubtful rules

build/.eslintrc

@@ -2,8 +2,17 @@
     "env": {
         "node": true
     },
+    "plugins": [
+        "node"
+    ],
+    "extends": [
+        "plugin:node/recommended"
+    ],
     "rules": {
-        "no-console": "off"
+        "no-console": "off",
+        "node/no-unpublished-require": "off",
+        "node/no-unsupported-features/node-builtins": "off",
+        "node/shebang": "off"
     },
     "globals": {
         "console": true

build/gulp/aspnet.js

@@ -1,3 +1,5 @@
+'use strict';
+
 const gulp = require('gulp');
 const merge = require('merge-stream');
 const rename = require('gulp-rename');

build/gulp/bundler-config.js

@@ -1,3 +1,5 @@
+'use strict';
+
 const gulp = require('gulp');
 const replace = require('gulp-replace');
 const concat = require('gulp-concat');

build/gulp/compression-pipes.js

@@ -1,3 +1,5 @@
+'use strict';
+
 const lazyPipe = require('lazypipe');
 const replace = require('gulp-replace');
 const uglify = require('gulp-uglify');

build/gulp/context.js

@@ -1,3 +1,5 @@
+'use strict';
+
 // See tests in version-spec.js
 
 const argv = require('yargs')

build/gulp/css-bundles.js

@@ -1,3 +1,5 @@
+'use strict';
+
 const fs = require('fs');
 const path = require('path');
 const gulp = require('gulp');

build/gulp/gulp-data-uri.js

@@ -1,3 +1,5 @@
+'use strict';
+
 const replace = require('gulp-replace');
 const path = require('path');
 const fs = require('fs');

build/gulp/header-pipes.js

@@ -1,3 +1,5 @@
+'use strict';
+
 const fs = require('fs');
 const lazyPipe = require('lazypipe');
 const header = require('gulp-header');

build/gulp/js-bundles.js

@@ -1,3 +1,5 @@
+'use strict';
+
 const path = require('path');
 const gulp = require('gulp');
 const gulpIf = require('gulp-if');

build/gulp/localization.js

@@ -1,3 +1,5 @@
+'use strict';
+
 const gulp = require('gulp');
 const path = require('path');
 const rename = require('gulp-rename');

build/gulp/npm.js

@@ -1,3 +1,5 @@
+'use strict';
+
 const gulp = require('gulp');
 const eol = require('gulp-eol');
 const replace = require('gulp-replace');
@@ -56,7 +58,7 @@ const addDefaultExport = lazyPipe().pipe(function() {
         const moduleMeta = MODULES.filter(m => m.name === moduleName)[0];
 
         if(moduleMeta && moduleMeta.exports && moduleMeta.exports.default) {
-            chunk.contents = new Buffer(String(chunk.contents) + 'module.exports.default = module.exports;');
+            chunk.contents = Buffer.from(String(chunk.contents) + 'module.exports.default = module.exports;');
         }
         callback(null, chunk);
     });

build/gulp/scss/common-replacements.js

@@ -1,3 +1,5 @@
+'use strict';
+
 module.exports = {
     // regex, replacement - replace
     // import, type - additional import (

build/gulp/scss/compiler.js

@@ -1,3 +1,5 @@
+'use strict';
+
 const sass = require('gulp-dart-sass');
 const gulp = require('gulp');
 const del = require('del');

build/gulp/scss/config.js

@@ -1,3 +1,5 @@
+'use strict';
+
 module.exports = {
     outputPath: 'scss',
     unfixedScssPath: 'styles'

build/gulp/scss/generator.js

@@ -1,3 +1,5 @@
+'use strict';
+
 const gulp = require('gulp');
 const path = require('path');
 const fs = require('fs');
@@ -98,7 +100,7 @@ gulp.task('fix-bundles', gulp.parallel(
             ];
             let content = chunk.contents.toString();
             widgets.forEach(widget => content += `@use "../widgets/common/${widget}";\n`);
-            chunk.contents = new Buffer(content);
+            chunk.contents = new Buffer.from(content);
             callback(null, chunk);
         }))
         .pipe(gulp.dest(`${outputPath}/bundles`))
@@ -153,7 +155,7 @@ gulp.task('fix-base', () => {
             let content = file.contents.toString();
             content = replaceColorFunctions(content);
             content = replaceInterpolatedCalcContent(content);
-            file.contents = new Buffer(content);
+            file.contents = Buffer.from(content);
             callback(null, file);
         }))
         .pipe(rename((path) => {
@@ -176,7 +178,7 @@ gulp.task(function fixCommon() {
             content = `@use "../base/mixins" as *;\n// adduse\n${content}`;
             content = commonSpecificReplacement(content, chunk.path);
             content = replaceInterpolatedCalcContent(content);
-            chunk.contents = new Buffer(content);
+            chunk.contents = Buffer.from(content);
             callback(null, chunk);
         }))
         .pipe(gulp.dest(`${outputPath}/widgets/common`));
@@ -296,7 +298,7 @@ gulp.task('create-widgets', () => {
             indexContent = replaceColorFunctions(indexContent);
             indexContent = replaceInterpolatedCalcContent(indexContent);
             indexContent = indexContent.replace(parentSelectorRegex, parentSelectorReplacement);
-            chunk.contents = new Buffer(indexContent);
+            chunk.contents = Buffer.from(indexContent);
 
             let colorsContent = '@use "sass:color";\n';
             colorsContent += '@use "../sizes" as *;\n';

build/gulp/scss/index-data.js

@@ -1,3 +1,5 @@
+'use strict';
+
 module.exports = [
     // each object has one of these tasks:
     // widget - widget reference

build/gulp/scss/tasks.js

@@ -1,3 +1,5 @@
+'use strict';
+
 require('./compiler');
 require('./generator');
 

build/gulp/scss/tests/identical.test.js

@@ -1,3 +1,5 @@
+'use strict';
+
 const fs = require('fs');
 const path = require('path');
 const cssom = require('cssom');
@@ -179,4 +181,4 @@ files.forEach(file => {
     }
 });
 
-process.exit(exitCode);
+process.exit(exitCode); // eslint-disable-line no-process-exit

build/gulp/scss/theme-replacements.js

@@ -1,3 +1,5 @@
+'use strict';
+
 module.exports = {
     // regex, replacement - replace
     // import, type - additional import (

build/gulp/style-compiler.js

@@ -1,3 +1,5 @@
+'use strict';
+
 const gulp = require('gulp');
 const path = require('path');
 const replace = require('gulp-replace');

build/gulp/themebuilder-npm.js

@@ -1,3 +1,5 @@
+'use strict';
+
 const gulp = require('gulp');
 const babel = require('gulp-babel');
 const jsonEditor = require('gulp-json-editor');

build/gulp/transpile.js

@@ -1,3 +1,5 @@
+'use strict';
+
 const gulp = require('gulp');
 const babel = require('gulp-babel');
 const watch = require('gulp-watch');

build/gulp/ts.js

@@ -1,3 +1,5 @@
+'use strict';
+
 const gulp = require('gulp');
 const file = require('gulp-file');
 const footer = require('gulp-footer');

build/gulp/vectormap.js

@@ -1,3 +1,5 @@
+'use strict';
+
 const gulp = require('gulp');
 const path = require('path');
 const fs = require('fs');

build/gulp/vendor.js

@@ -1,3 +1,5 @@
+'use strict';
+
 const gulp = require('gulp');
 const rename = require('gulp-rename');
 const merge = require('merge-stream');

build/gulp/version-spec.js

@@ -1,6 +1,8 @@
 // Tests for the version.js module
 // Note: label and revision can't be set at the same time
 
+'use strict';
+
 const versionFunc = require('./version');
 
 const cases = [

build/gulp/version.js

@@ -1,3 +1,5 @@
+'use strict';
+
 const envTail = 'DEVEXTREME_TMP_TAIL';
 
 if(!process.env[envTail]) {

build/npm-bin/bundler-init.js

@@ -1,4 +1,5 @@
 #!/usr/bin/env node
+'use strict';
 
 const fs = require('fs');
 const path = require('path');

build/npm-bin/bundler.js

@@ -1,4 +1,5 @@
 #!/usr/bin/env node
+'use strict';
 
 const path = require('path');
 const webpack = require('webpack');
@@ -10,7 +11,7 @@ let bundle = process.argv.length > 2 ? process.argv[2] : 'dx.custom';
 
 bundle = bundle.replace(/.config.js$/, '');
 
-const baseConfig = require('./webpack.config.js');
+const baseConfig = require('./webpack.config.js'); // eslint-disable-line node/no-missing-require
 const createConfig = function(outputFile, mode) {
     const config = Object.assign({}, baseConfig);
 

build/vectormap-sources/_settings.js

@@ -1,3 +1,5 @@
+'use strict';
+
 module.exports = {
     isQuiet: true
 };

package.json

@@ -57,6 +57,7 @@
     "devextreme-cldr-data": "^1.0.2",
     "devextreme-internal-tools": "~1.2.0",
     "eslint": "^7.0.0",
+    "eslint-plugin-node": "^11.1.0",
     "eslint-plugin-qunit": "^4.0.0",
     "eslint-plugin-spellcheck": "0.0.11",
     "exceljs": "3.3.1",