You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Currently, the pyproject.toml file has the standards tables defined in PEP 517 (build-system) and PEP 621 (project). And it has support for a couple of tools: Ruff (tool.ruff) and Poetry (tool.poetry). There's proposed support for Hatch (tool.hatch) as well. I'd like to add several more; I've created tool.cibuildwheel, tool.scikit-build, and tool.repo-review, all in their respective repos1. I also know where the schema for tool.setuptools is, and I know the author, so we could probably get that added. I'd also love to see common tools like pytest and mypy get subschemas.
This brings me to the request: Ruff and the proposed Hatch are subschemas, but for some reason (probably age) Poetry is built into the pyproject.toml file schema, even though it is just a tool section and not standards-based. I thin it seems much cleaner for all tools to have their own subschema, and Poetry plans (very eventually) to adopt PEP 621 and migrate away from putting everything in tool.poetry, so keeping it separate as a subschema and avoiding complicating main schema seems like a reasonable idea. Would that be acceptable? I could work on splitting it out if it's a good idea.
(This also has the benefit that it would be then reusable for validate-pyproject, which requires all tool sections to be subschemas).
Supporting information.
This one's already present, the request is just to split it out, so assuming you don't need extra info?
EDIT: I think this might be a feature request, because unlike Ruff, Poetry (along with setuptools, pytest, scikit-build, mypy, etc) don't support a secondary TOML-based config file format; the only TOML-based config is via pyproject.toml. When I tried this, I get Schema file name must be present in the catalog URL.. But adding all of them to a single file would be terrifying. EDIT-EDIT: Ahh, you can leave the file names empty.
Are you making a PR for this?
Yes, I will create a PR.
Footnotes
Unrelated question: is it better to host these directly from the project repos's main branch, or should I make a copy when I contribute them? Both seem to be possible, not sure what's preferred here. EDIT: Ahh, I think Referencing an external schema by its URL within a local schema #2731 answers my question. :) ↩
The text was updated successfully, but these errors were encountered:
Description of the JSON schema.
Currently, the pyproject.toml file has the standards tables defined in PEP 517 (
build-system
) and PEP 621 (project
). And it has support for a couple of tools: Ruff (tool.ruff
) and Poetry (tool.poetry
). There's proposed support for Hatch (tool.hatch
) as well. I'd like to add several more; I've createdtool.cibuildwheel
,tool.scikit-build
, andtool.repo-review
, all in their respective repos1. I also know where the schema fortool.setuptools
is, and I know the author, so we could probably get that added. I'd also love to see common tools like pytest and mypy get subschemas.This brings me to the request: Ruff and the proposed Hatch are subschemas, but for some reason (probably age) Poetry is built into the pyproject.toml file schema, even though it is just a tool section and not standards-based. I thin it seems much cleaner for all tools to have their own subschema, and Poetry plans (very eventually) to adopt PEP 621 and migrate away from putting everything in tool.poetry, so keeping it separate as a subschema and avoiding complicating main schema seems like a reasonable idea. Would that be acceptable? I could work on splitting it out if it's a good idea.
(This also has the benefit that it would be then reusable for validate-pyproject, which requires all tool sections to be subschemas).
Supporting information.
This one's already present, the request is just to split it out, so assuming you don't need extra info?
EDIT: I think this might be a feature request, because unlike Ruff, Poetry (along with setuptools, pytest, scikit-build, mypy, etc) don't support a secondary TOML-based config file format; the only TOML-based config is via pyproject.toml. When I tried this, I get
Schema file name must be present in the catalog URL.
. But adding all of them to a single file would be terrifying. EDIT-EDIT: Ahh, you can leave the file names empty.Are you making a PR for this?
Yes, I will create a PR.
Footnotes
Unrelated question: is it better to host these directly from the project repos's main branch, or should I make a copy when I contribute them? Both seem to be possible, not sure what's preferred here. EDIT: Ahh, I think Referencing an external schema by its URL within a local schema #2731 answers my question. :) ↩
The text was updated successfully, but these errors were encountered: