-
-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add AutoMooncake type #89
Conversation
|
Can we have a default setting so that people don't need to dig into the |
We could do that. I'd prefer to prevent people from writing |
Sounds good, let's do that. As a user of ADTypes it's always a bit painful to go grab a specific type from a package to configure backends (like |
Ready for review? |
Yes, go for it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this contribution! Most of my remarks are esthetics, fundamentally it is good to go
Checklist
contributor guidelines, in particular the SciML Style Guide and
COLPRAC.
Additional context
AutoTapir
needs to be deprecated in favour ofAutoMooncake
, because Tapir.jl has been renamed to Mooncake.jl.I could do with some advice on the appropriate way to deprecate
AutoTapir
-- should I just add the constructor to thelegacy.jl
file, or is there something else that I should do?